8993 regex: Refactor fast/slow stepping bits in the matching engine

Review Request #2315 — Created Sept. 19, 2019 and submitted

Information
yuripv
illumos-gate
master
8993
2342, 2343
1bd069a...
Reviewers
general 
From upstream commit:


Adding features for matching is fairly straightforward, but this requires

some duplication because of this fast/slow setup. They can be fairly

trivially combined into a single walk(), so do it to make future additions

less error prone.
regex tests
  • 0
  • 0
  • 0
  • 1
  • 1
Description From Last Updated
tsoome
tsoome 
  1. 
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
      usr/src/lib/libc/port/regex/regcomp.c
      


       (Diff revision 1)


      
     
    
    
       
   
    
     
    

    
     
    

       
  
    
 
    

   
    
    
    



    
 
    
  
    
   
   
    
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    cstyle does want boolean operator here (both in freebsd and illumos:)
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      cstyle (as in cstyle.pl) does NOT, and as there's no MUST wording involved, I prefer to keep the original "upstream" style (and it's generally not cstyle clean for the same reason).
      
 
      

      2. 


 
    


    

 
    

    3. 




  3. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  

 
















 





 

  

   




rm




   

   







  

 



 

  


   

   

    
 
rm


    
   


  

  

  



    




  1. 
 
    
  
    
   
    This looks reasonable, though I'm not sure I have much confidence in my understanding of the branching code that was added.
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   




yuripv




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  






 

  Status:
  

  Closed (submitted)

  
 







 


 










  

 









     

    

   

  

  

   
   Loading...