5321 Convenience scripts to build/clean smbsrv, idmap, zfs
Review Request #23 — Created April 10, 2015 and submitted
Information | |
---|---|
gwr | |
illumos-gate | |
5321 | |
Reviewers | |
general | |
These are some convenience scripts we use for developer "partial builds".
It makes my life a little easier upstreaming the rest of our SMB work
if I can integrate these, because later changes add to them.
In use for quite a while at Nexenta.
-
I mostly just looked at the make-zfs script, but it looks good to me. I think we'll try replace our internal script and instead use the 'make-zfs' included here after this lands.
The only thing I don't like is the fact that there's so much code duplication between the scripts. At some point (in a later patch) it might be good to move the common code to another file, and then "source" it into the actual scripts.
-
usr/src/tools/quick/make-zfs (Diff revision 1) at delphix, we're also building:
$SRC/uts/intel/kmdb
$SRC/uts/intel/devin our list of kernel directories. should those two be added to the list here? (probably with s/intel/$x/)
-
usr/src/tools/quick/make-zfs (Diff revision 1) I think we may have accumulated some cruft here, but we're also building these libs:
libc
libnvpair
libsec
libdevinfo
libbrand
libzonecfg
libinetutil
libladm
libdlpi
libdiskmgt
libumem
libdisasm
libidmap
libdevidshould any of these be listed here too?
I see there's some overlap between my list and the list in 'do_hdrs' so maybe we were just being lazy and doing a 'make install' when we really just needed a 'make install_h'...
-
usr/src/tools/quick/make-zfs (Diff revision 1) Our script at delphix is also building the cmds:
isaexec
platexec
syseventd
zinject
terminfo
mdbdoes it make sense to pull these directories in here too? I can't remember why we build all of these, but I think we'd definitely need to add zinject and mdb if we were to move over to using this tool instead our internal one.
-
usr/src/tools/quick/make-zfs (Diff revision 1) should this be moved into the 'for cmd in' list above? is it split out here for a special reason?
-
usr/src/tools/quick/make-zfs (Diff revision 1) similar to mdb, is this "better" than doing 'cd $SRC/cmd/syseventd && $make $1' ? just curious..
-
usr/src/tools/quick/make-zfs (Diff revision 1) is this "better" than just 'cd $SRC/cmd/mdb && $make $1' ? that's what we're doing at delphix, so I'm just curious what the different is..
-
usr/src/tools/quick/make-zfs (Diff revision 1) how about adding the directories for zdb, zinject and mdb too?
Change Summary:
Add a few directories, plus a new "deplibs" target as discussed with Prakash Surya.
Diff: |
Revision 2 (+1193) |
---|