7661 illumos should provide 64bit perl modules

Review Request #2284 — Created Sept. 6, 2019 and submitted

andy_js
illumos-gate
7661
general

My Omni bloody install which I use for integration testing hasn't been working right for a while. It seems the system version of perl is 64bit, but the modules installed by illumos are 32bit. An option to build 64bit modules as well would solve this issue.

Full build of illumos-gate.

  • 0
  • 0
  • 2
  • 1
  • 3
Description From Last Updated
ptribble
  1. 
      
  2. usr/src/tools/env/illumos.sh (Diff revision 1)
     
     

    What happens if someone now does a build with an old style illumos.sh?

    As far as I can tell, that would set PERL_ARCH64 incorrectly, but would also disable both 32-bit and 64-bit perl modules, which might be surprising.

    1. Actually the PERL_VARIANT part (which I assume you're referring to) is only required for OmniOS where perl is built with threading enabled. Leaving PERL_VARIANT unset will result in PERL_ARCH64 being set to i86pc-solaris-64 which for OI would probably be correct.

  3. 
      
tsoome
  1. Ship It!
  2. 
      
andy_js
andy_js
citrus
  1. 
      
  2. usr/src/Makefile.master (Diff revision 3)
     
     

    I think the default should be at least to enable the 32-bit modules. Not everyone will pick up a new illumos.env with these enabled.

  3. usr/src/Makefile.master (Diff revision 3)
     
     

    Add an explicit PERL_VARIANT= here for completeness?

    1. Will do.

    2. Thanks - I'm just doing a full build of gate + this patch on OmniOS.

  4. 
      
andy_js
citrus
  1. Ship It!
  2. 
      
andy_js
citrus
  1. Ship It!
  2. 
      
tsoome
  1. Ship It!
  2. 
      
andy_js
Review request changed

Status: Closed (submitted)

Loading...