11661 provide C.UTF-8 locale

Review Request #2283 — Created Sept. 6, 2019 and submitted

yuripv
illumos-gate
master
11661
1333d2d...
general

Provide hybrid C.UTF-8 locale having all the characteristics of default C/POSIX locale, except for LC_CTYPE data.



  • 0
  • 0
  • 1
  • 2
  • 3
Description From Last Updated
tsoome
  1. Ship It!
  2. 
      
rm
  1. 
      
  2. usr/src/data/locale/data/C.UTF-8.src (Diff revision 1)
     
     
    Why is this a placeholder? That makes it sound like this file isn't complete.
    1. That's how we build LC_CTYPE data files, LC_CTYPE section in *.src gets removed, and replaced with common.UTF-8.src, but the file itself should exist, so it's a placeholder. This could be improved, probably, but I wanted as small change as possible.

    2. OK, gotcha. I think it would be a lot clearer if you describe that in the comment there. When I first read placeholder, I thought that this was an interim step in the creation of the locale.

    3. Thinking a bit more about it, with this change, the LC_CTYPE data file that is the same for all UTF-8 locales will now be shipped in SUNWcs, so always present. That will allow us to make all other locale's LC_CTYPE data files be a hardlink to this one, and will save us some build time. But that's for separate change.

    4. OK, comment updated.

    5. Thanks for doing so! Hardlinking those together sounds neat. Sounds like a useful future change.

  3. usr/src/data/locale/data/C.UTF-8.src (Diff revision 1)
     
     
     
    Should there actually be no data in this section at all? All the other locales actually have data in them here.
    1. Yes, all LC_CTYPE data comes from common.UTF-8.src.

  4. Rather than the unused comment here, I think it might help to explain that the LC_CTYPE data will actually be loaded by the system in the same way that other data is.
    1. That field is indeed unused, so I have added the relevant information to the comment above the structure.

  5. 
      
igork
  1. Ship It!
  2. 
      
yuripv
yuripv
rm
  1. Ship It!
  2. 
      
yuripv
Review request changed

Status: Closed (submitted)

Loading...