11649 loader.efi: some systems do not translate scan code 0x8 to backspace

Review Request #2277 — Created Sept. 2, 2019 and submitted

Information
tsoome
illumos-gate
11649
eaa9dad...
Reviewers
general 
11649 loader.efi: some systems do not translate scan code 0x8 to backspace




 













 

 














  

 








 














 



 

  

   




tsoome




   

   

  

 



 















 





 

  

   




domag02




   

   







  

 



 

  


   

   

    
 
domag02


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship it!
    

    Maybe worth to add this to the definition list of 'Baseline unicode control chars' in eficon.h:
    

    #define CHAR_ESCAPE            0x001B

    

    

    At least with the usage of this preprocessor macro you don't have to comment everywhere the meaning of 0x1b magic number.
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      It is tempting, but those headers are coming from edk2 and I would rather avoid changing them too much.
      
 
      

      2. 


 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   




tsoome




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  






 

  Status:
  

  Closed (submitted)

  
 







 


 










  

 









     

    

   

  

  

   
   Loading...