11643 panic when detaching vioif

Review Request #2274 — Created Aug. 29, 2019 and submitted

citrus
illumos-gate
master
11643
894901a...
general
11643 panic when detaching vioif

Repeated loading and unloading of the vioif module.

  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
jclulow
  1. One comment nit, but otherwise looks good! My apologies for not having done better with testing the detach path here.

  2. usr/src/uts/common/io/vioif/vioif.c (Diff revision 1)
     
     

    Remove the blank line, so that the comment touches the call to vioif_free_bufs()?

  3. 
      
citrus
jclulow
  1. Ship It!
  2. 
      
richlowe
  1. The bug could do with more (some) detail about the cause. I see what' wrong in the review, but I don't see why the flag change in the last hunk, nor the mac_fini() change in the first hunk relate.

    1. Oh, and the switch to the locked device reset, too

    2. Josh has updated the bug description to include all of the issues found and fixed by this.
      The other issues showed up under kmem debugging or after the first panic cause was fixed.

  2. 
      
tsoome
  1. The patch looks good, but yes I do agree, the issue description needs few lines about the issues addressed here.

  2. 
      
rm
  1. Ship It!
  2. 
      
richlowe
  1. Ship It!
  2. 
      
citrus
Review request changed

Status: Closed (submitted)

Loading...