11643 panic when detaching vioif
Review Request #2274 - Created Aug. 29, 2019 and submitted
| Information | |
|---|---|
| Andy Fiddaman | |
| illumos-gate | |
| master | |
| 11643 | |
| 894901a... | |
| Reviewers | |
| general | |
11643 panic when detaching vioif
Repeated loading and unloading of the vioif module.
Joshua Clulow
One comment nit, but otherwise looks good! My apologies for not having done better with testing the detach path here.
-
usr/src/uts/common/io/vioif/vioif.c (Diff revision 1) -
Remove the blank line, so that the comment touches the call to
vioif_free_bufs()?
Review request changed
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+9 -5) |
Ship It!
The bug could do with more (some) detail about the cause. I see what' wrong in the review, but I don't see why the flag change in the last hunk, nor the mac_fini() change in the first hunk relate.
The patch looks good, but yes I do agree, the issue description needs few lines about the issues addressed here.
Ship It!
Ship It!