11683 Automatically maintain whatis database

Review Request #2270 — Created Aug. 28, 2019 and submitted

citrus
illumos-gate
master
11683
6e19aec...
general
Automatically maintain whatis database


  • 0
  • 0
  • 5
  • 0
  • 5
Description From Last Updated
richlowe
  1. 
      
  2. usr/src/cmd/man/rebuild-whatis.xml (Diff revision 1)
     
     

    Can we not use better names here yet?

  3. 
      
richlowe
  1. 
      
  2. usr/src/cmd/man/rebuild-whatis (Diff revision 1)
     
     

    I think we're doing this to set PATH, so that man(1)s logic to set MANPATH from PATH comes into being, and causes us to re-index those directories. Right?

    If so, can we get a comment saying so?

    Also, do we want a better way of doing this, for people who'd want to extend that list?

    1. Yes, that's right. There is a comment lower down where PATH is set but I can expand it.

      Before this change, the usual way of rebuilding the database is to run man -w as root. That will use MANPATH if it happens to be in the logged-in user's environment, or derive the directories from PATH and append /usr/share/man. This smf service uses the default PATH that is set in /etc/default/login or falls back to /usr/sbin:/usr/bin if it is not set in there.

      Do you think it's necessary to provide an SMF property to specify additional directories to search?

    2. I think that's what I'd do, and default it to everywhere manual pages get delivered right now. It seems a lot easier than parsing etc/default/login, except for you've already done it :\

      Distributions have a way to set properties from SMF profiles, don't they, too? to customize that smoothly without having to change the default path?

  3. usr/src/cmd/man/rebuild-whatis.xml (Diff revision 1)
     
     

    I'd prefer a name that was more "what" than "how"
    update-man-index? something like that?

    I'm guessing changing it would hurt OmniOS though :\

    1. It can still be changed in OmniOS.

  4. 
      
citrus
yuripv
  1. Ship It!
  2. 
      
citrus
yuripv
  1. 
      
  2. usr/src/cmd/man/Makefile (Diff revision 3)
     
     

    Remove this if you are removing the lint target?

  3. usr/src/cmd/man/update-man-index (Diff revision 3)
     
     

    Do ween these lines added to what's in usr/src/prototypes/? Don't seem to serve any purpose.

    1. I think they used to be in the old prototypes.. they have made it into my C named buffer in vim. Now removed and sorted.

    2. I'm sorry for nitpicking, but if these are useful, let's add them to prototypes, if not, let's not add them.

  4. usr/src/cmd/man/update-man-index.xml (Diff revision 3)
     
     

    Remove?

  5. 
      
citrus
richlowe
  1. I'm happy with these updates, but I specifically never remember how to use IFS properly.

  2. 
      
yuripv
  1. Ship It!
  2. 
      
citrus
Review request changed

Status: Closed (submitted)

Loading...