7443 smbfs should present DOS attributes

Review Request #227 — Created Oct. 2, 2016 and submitted

Information
gwr
illumos-gate
7443
Reviewers
general 
7443 smbfs should present DOS attributes
Access through smbfs to "NT named streams", as well as "ls -/ c" to see DOS attributes etc.
jjelinek
jjelinek 
  1. I'm not very familiar with SMB but overall this looks good. I just had a few small comments.
    

    smbfs_client.c
    
453 I'm not familiar with review board. Is this a line with trailing white space?
    
517 Normally 'XXX' is used to denote work TBD. Is there more to do here? If not can this comment be improved?
    

    smbfs_vnops.c
    
1092 Does this comment need to be fixed up now that you are handling DOS attrs?
    1. Yes, white space fixed.
      
XXX was a reminer to take that out (thanks!;)
      
Correct re. comment in vnops (we may set dosattr now:)
      
All good caches.
  2. 
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   




gwr




   

   

  

 



 















 



 

  

   




gwr




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  






 

  Status:
  

  Closed (submitted)

  
 







 


 










  

 









     

    

   

  

  

   
   Loading...