11635 ip: passing argument 2 of 'cc_cong_signal' makes integer from pointer without a cast

Review Request #2269 - Created Aug. 28, 2019 and submitted

Information
Toomas Soome
illumos-gate
11635
8e25ea5...
Reviewers
general
../../common/inet/tcp/tcp_timers.c: In function 'tcp_timer':
../../common/sys/null.h:28:14: error: passing argument 2 of 'cc_cong_signal' mak
es integer from pointer without a cast [-Werror=int-conversion]
 #define NULL ((void *)0)
              ^
../../common/inet/tcp/tcp_timers.c:787:25: note: in expansion of macro 'NULL'
     cc_cong_signal(tcp, NULL, CC_RTO);
                         ^~~~
In file included from ../../common/inet/tcp/tcp_timers.c:42:0:
../../common/inet/tcp_impl.h:738:13: note: expected 'uint32_t {aka unsigned int}
' but argument is of type 'void *'
 extern void cc_cong_signal(tcp_t *, uint32_t, uint32_t);
             ^~~~~~~~~~~~~~
cc1: all warnings being treated as errors

  
John Levon
Andrew Stormont
Toomas Soome
Toomas Soome
Review request changed

Status: Closed (submitted)

Loading...