11631 SPARC NULL pointer error in libds

Review Request #2265 — Created Aug. 28, 2019 and submitted Sept. 7, 2019, 10:45 a.m.

Information
Owner:	ptribble
Repository:	illumos-gate
Branch:
Bugs:	11631
Depends On:
Reviewers
Groups:	general
People:

Description

NULL pointer errors building libds on SPARC:

../common/libds.c:105: error: passing argument 1 of 'ds_hdl_to_dslibentry' makes integer from pointer without a cast
../common/libds.c:128: error: comparison between pointer and integer
../common/libds.c:145: error: comparison between pointer and integer
../common/libds.c:204: error: assignment makes integer from pointer without a cast
../common/libds.c:300: error: assignment makes integer from pointer without a cast
../common/libds.c:717: error: comparison between pointer and integer

Testing Done

Build clean; wsdiff shows no changes.

Issues

0
0
0
1
All Issues: 1

Description	From	Last Updated
How about using DS_INVALID_HDL instead of the literal 0? (Ship it either way)	citrus	Sept. 6, 2019, 7:55 p.m.

Ship it!

```
Ship It!
```

Ship it!

usr/src/lib/libds/common/libds.c (Diff revision 1)

Show all issues

How about using DS_INVALID_HDL instead of the literal 0?

(Ship it either way)

ptribble Sept. 6, 2019, 7:55 p.m.

Looking through libds.c, all other comparisons on a dsl_hdl (which is what the ds_hdl_to_dslibentry does) are to a literal 0, so I think 0 is fine for consistency.

You have a pending review.

Review Board 3.0.18

11631 SPARC NULL pointer error in libds

Status: Closed (submitted)