11593 iscsi: cast between incompatible function types
Review Request #2246 — Created Aug. 21, 2019 and submitted
Information | |
---|---|
tsoome | |
illumos-gate | |
11593 | |
bec11d0... | |
Reviewers | |
general | |
../../common/io/scsi/adapters/iscsi/iscsi_login.c:238:8: error: cast between incompatible function types from 'iscsi_status_t (*)(void *)' {aka 'enum iscsi_status (*)(void *)'} to 'void (*)()' [-Werror=cast-function-type] (void(*)())iscsi_login_start, itp, DDI_SLEEP) != ^ ../../common/io/scsi/adapters/iscsi/iscsi_conn.c:1052:6: error: cast between incompatible function types from 'iscsi_status_t (*)(void *)' {aka 'enum iscsi_status (*)(void *)'} to 'void (*)()' [-Werror=cast-function-type] (void(*)())iscsi_login_start, itp, DDI_SLEEP) != ^ cc1: all warnings being treated as errors
-
-
usr/src/uts/common/io/scsi/adapters/iscsi/iscsi.h (Diff revision 1) The name looks too generic, may be
iscsi_login_cb
?
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 2 (+9 -2) |
Change Summary:
whitespace nits.
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 3 (+13 -8) |