11576 Want support for ahci LED entries in topo

Review Request #2235 — Created Aug. 18, 2019 and submitted

rm
illumos-gate
master
11576
aeb2428...
general

11576 Want support for ahci LED entries in topo
Reviewed by: Rob Johnston <rob.johnston@joyent.com>
Reviewed by: Robert Mustacchi <rm@joyent.com>



  • 0
  • 0
  • 0
  • 2
  • 2
Description From Last Updated
seeemef@mac.com
  1. 
      
  2. I'm afraid I don't follow why \n is used with all but two topo_mod_dprintf() calls in this function but I think not used elsewhere with such calls in this patch.

    1. So, there's really no difference between using them or not in the code. This isn't like mdb where not having a \n is semantically different. In fact, topo_mod_dprintf will insert a final \n if you don't for you. In this case, I suspect it's just a matter of when they were written in the development cycle and/or their origin.

  3. 
      
rm
  1. 
      
  2. So, there's really no difference between using them or not in the code. This isn't like mdb where not having a \n is semantically different. In fact, topo_mod_dprintf will insert a final \n if you don't for you. In this case, I suspect it's just a matter of when they were written in the development cycle and/or their origin.

    1. Oos, this was meant to be a reply.

  3. 
      
seeemef@mac.com
  1. Ah OK. LGTM

  2. 
      
rm
Review request changed

Status: Closed (submitted)

Loading...