7439 libsqlite always rebuilds after illumos 6648

Review Request #223 — Created Sept. 30, 2016 and submitted Oct. 3, 2016, 8:37 p.m.

Information
Owner:	gwr
Repository:	illumos-gate
Branch:
Bugs:	7439
Depends On:
Reviewers
Groups:	general
People:

Description

The reason this happens is that CFLAGS is an inherited macro that's set differently (via conditional assignment involving PICFLAGS) when we're building the pic/*.o library objects vs. building the lint libraries etc.

Before #6648 was fixed, this makefile omitted CFLAGS, which masked this problem.
Have a fix which prevents PICFLAGS inheritance when building the "lemon" tool.

Testing Done

Build twice in $SRC/lib/libsqlite

Issues

0
0
0
1
All Issues: 1

Description	From	Last Updated
on this line you can use: $(NATIVECC) $(NATIVE_CFLAGS) -o $@ $< others - LGTM	igork	Sept. 30, 2016, 7:39 p.m.

Ship it!

```
Ship It!
```

usr/src/lib/libsqlite/Makefile.com (Diff revision 1)

Show all issues

on this line you can use:

$(NATIVECC) $(NATIVE_CFLAGS) -o $@ $<
others - LGTM

gwr Sept. 30, 2016, 6:33 p.m.
```
nohup nightly -i gwr-illumos </dev/null
```

gwr Sept. 30, 2016, 6:34 p.m.

That was weird. RB pasted something other than what I had highlighted...
Anyway, question below...

gwr Sept. 30, 2016, 7:39 p.m.

Actually, I tried replacing that as you suggested, but make left $< empty so the rule fails.
Let's just go with what I know works (which we've been using for a year).

usr/src/lib/libsqlite/Makefile.com (Diff revision 1)

OK, but is that worth the trouble to change?

igork Sept. 30, 2016, 7:03 p.m.

you need copy/past the same target what you have in input - with my proposed rule you need control only one list of file(s), but up to you - if we use only one static file here

gwr Sept. 30, 2016, 7:07 p.m.
```
OK
```

I reviewed this initially, and am still scared by the fact it works, but I'm happy with the fact it does work.

It seems like it working (or not working, or in fact being different) suggests there's a bug in make somewhere :(

gwr Sept. 30, 2016, 8:08 p.m.

Yeah, it's perhaps non-obvious, but it works because inheritance of target-dependent assignments does not continue into sub-invocations of $(MAKE).

Ship it!

```
Ship It!
```

You have a pending review.

Review Board 3.0.18

7439 libsqlite always rebuilds after illumos 6648

Status: Closed (submitted)