11549 loader: smatch error: efi_cons_cursor(): uninitialized symbol 'row' and 'col'

Review Request #2221 — Created Aug. 13, 2019 and submitted Aug. 14, 2019, 1:23 p.m.

Description

11549 loader: smatch error: efi_cons_cursor(): uninitialized symbol 'row' and 'col'

Testing Done

Can't you re-enable the uninitialized check in the makefile then?

update makefile.

-	1f62873763aba6aabd9bd41bbfc1d4120c331a26
+	bcd424af17011bdb2e4eef4fd7d96f002743f164

	usr/src/boot/Makefile.version
	usr/src/boot/sys/boot/efi/libefi/efi_console.c
	usr/src/boot/sys/boot/efi/libefi/i386/Makefile

Ship it!

Ship it!

cstyle cleanup.

-	bcd424af17011bdb2e4eef4fd7d96f002743f164
+	3bc205686cf3f188791bfdf0f655f8abe4224bbc

	usr/src/boot/Makefile.version
	usr/src/boot/sys/boot/efi/libefi/efi_console.c
	usr/src/boot/sys/boot/efi/libefi/i386/Makefile

You have a pending review.