11533 tools/make: gcc9 build errors 11534 tools/make: remove sys_nerr 11535 tools/make: amd64 arch is not supported 11536 tools/make: getmem() should take size_t
Review Request #2216 - Created Aug. 9, 2019 and submitted
| Information | |
|---|---|
| Toomas Soome | |
| illumos-gate | |
| 11533, 11534, 11535, 11536 | |
| e298524... | |
| Reviewers | |
| general | |
/code/gcc9/usr/src/cmd/make/lib/mksh/dosys.cc: In function 'void sh_command2stri
ng(String, String)':
/code/gcc9/usr/src/cmd/make/lib/mksh/dosys.cc:534:20: error: invalid conversion
from 'int' to 'wchar_t*' [-fpermissive]
534 | command->text.p = (int) nul_char;
| ^~~~~~~~~~~~~~
| |
| int
*** Error code 1
/code/gcc9/usr/src/cmd/make/lib/vroot/lock.cc: In function 'int file_lock(char*, char*, int*, int)':
/code/gcc9/usr/src/cmd/make/lib/vroot/lock.cc:112:14: error: cast from 'char*' to 'int' loses precision [-fpermissive]
112 | (int) name, (int) lockname);
| ^~~~
/code/gcc9/usr/src/cmd/make/lib/vroot/lock.cc:112:26: error: cast from 'char*' to 'int' loses precision [-fpermissive]
112 | (int) name, (int) lockname);
| ^~~~~~~~
Andy Fiddaman
Review request changed
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+60 -60) |
-
usr/src/cmd/make/lib/mksh/misc.cc (Diff revision 2) -
Ditch these comments too?
-
usr/src/cmd/make/lib/mksh/misc.cc (Diff revision 2) -
6 for "Error ", 1 for?, 11 for digits?, 1 for terminator...
Review request changed
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 3 (+60 -64) |
Ship It!