7404 rootpool_007_neg, bootfs_006_pos and bootfs_008_neg tests fail with the loader project bits

Review Request #221 — Created Sept. 26, 2016 and submitted

tsoome
illumos-gate
7404
74e31a3...
general

7404 rootpool_007_neg, bootfs_006_pos and bootfs_008_neg tests fail with the loader project bits

Test: /opt/zfs-tests/tests/functional/bootfs/bootfs_001_pos (run as root) [00:00] [PASS]
Test: /opt/zfs-tests/tests/functional/bootfs/bootfs_002_neg (run as root) [00:00] [PASS]
Test: /opt/zfs-tests/tests/functional/bootfs/bootfs_003_pos (run as root) [00:00] [PASS]
Test: /opt/zfs-tests/tests/functional/bootfs/bootfs_004_neg (run as root) [00:00] [PASS]
Test: /opt/zfs-tests/tests/functional/bootfs/bootfs_005_neg (run as root) [00:05] [PASS]
Test: /opt/zfs-tests/tests/functional/bootfs/bootfs_006_pos (run as root) [00:01] [PASS]
Test: /opt/zfs-tests/tests/functional/bootfs/bootfs_007_pos (run as root) [00:00] [PASS]
Test: /opt/zfs-tests/tests/functional/bootfs/bootfs_008_pos (run as root) [00:00] [PASS]
Test: /opt/zfs-tests/tests/functional/rootpool/setup (run as root) [00:00] [PASS]
Test: /opt/zfs-tests/tests/functional/rootpool/rootpool_002_neg (run as root) [00:00] [FAIL]
Test: /opt/zfs-tests/tests/functional/rootpool/rootpool_003_neg (run as root) [00:00] [PASS]
Test: /opt/zfs-tests/tests/functional/rootpool/rootpool_007_pos (run as root) [00:00] [PASS]
Test: /opt/zfs-tests/tests/functional/rootpool/cleanup (run as root) [00:00] [PASS]

rootpool_002_neg seems to fail due to bug in test, from its error log:

filesystem 'rpool' cannot be mounted using 'mount -F zfs' Use 'zfs set mountpoint=/rpool' instead. If you must use 'mount -F zfs' or /etc/vfstab, use 'zfs set mountpoint=legacy'. See zfs(1M) for more information.

And its note related to gzip anyhow.

tsoome
yuripv
  1. You could rename bootfs_008_neg to bootfs_008_pos and check that setting bootfs will succeed on compressed FS (change assert and log_mustnot -> log_must). Also don't forget about runfiles (usr/src/test/zfs-tests/runfiles/).

    1. Yea, Igork noted the same, but then again, we dont test for lz4/lzjb do we?;) well, I'm fine either way, lets see if we get more opinions:)

    2. +1 for the rename. Either way, please do not forget to update the runfiles in usr/src/test/zfs-tests/runfiles/.

  2. 
      
tsoome
igork
  1. Ship It!
  2. 
      
tsoome
tsoome
igork
  1. Ship It!
    1. please submit it to openzfs project where they can check it by zfs tests

  2. 
      
marcel
  1. Ship It!
  2. 
      
mahrens
  1. Diffs look fine. Have you run the tests? If you need help you can submit a pull request to https://github.com/openzfs/openzfs/pulls and we will run the tests for you.

  2. 
      
tsoome
mahrens
  1. Ship It!
  2. 
      
igork
  1. Ship It!
  2. 
      
marcel
  1. Ship It!
  2. 
      
tsoome
Review request changed

Status: Closed (submitted)

Loading...