-
-
usr/src/cmd/zfs/zfs_main.c (Diff revision 1) C-style: "Do not nest the ternary conditional operator (?:)."
-
usr/src/cmd/zfs/zfs_main.c (Diff revision 1) C-style:
"Do not nest the ternary conditional operator (?:)."
11355 zfs create needs dry-run
Review Request #2208 — Created Aug. 2, 2019 and updated
Information | |
---|---|
mgerdts | |
illumos-gate | |
Reviewers | |
general | |
I first did this work in zfsonlinux and SmartOS. This should bring zfsonlinux, SmartOS, and illumos in sync.
https://github.com/zfsonlinux/zfs/commit/d45d7f08fa56f94fc9577a6578cb411071a42e8d
SmartOS, as a private option:
https://github.com/joyent/illumos-joyent/commit/b322ba367cdb75882f1cede5a8b22c7fd17ced94
SmartOS, now public:
https://github.com/joyent/illumos-joyent/commit/d0efab8443fcce33c336a009d253617419db9909
This has been exercised in SmartOS for a couple weeks, with it in the critical path for various bhyve instance operations (create, storage management) without any issues. Testing of the upstreamin work recorded in illumos#11355.
- 8
- 0
- 0
- 0
- 8
Description | From | Last Updated |
---|---|---|
We had an issue -- 4712 Prefer 'parsable' over 'parseable' in the manual pages -- let's stick to using parsable ... |
|
|
C-style: "Do not nest the ternary conditional operator (?:)." |
|
|
Missing gettext calls? |
|
|
C-style: "Do not nest the ternary conditional operator (?:)." |
|
|
Missing gettext calls? |
|
|
(everywhere) use fnvpair family of functions for better readability? |
|
|
Missing gettext calls? |
|
|
should be? |
|
-
-
usr/src/cmd/zfs/zfs_main.c (Diff revision 1) We had an issue -- 4712 Prefer 'parsable' over 'parseable' in the manual pages -- let's stick to using
parsable
everywhere? -
usr/src/cmd/zfs/zfs_main.c (Diff revision 1) (everywhere) use fnvpair family of functions for better readability?
-
-
-
-
usr/src/cmd/zfs/zfs_main.c (Diff revision 1) Don't need to initialize
nvp
as you overwrite this value anyway below? -
-