11355 zfs create needs dry-run

Review Request #2208 - Created Aug. 2, 2019 and updated

Information
Mike Gerdts
illumos-gate
Reviewers
general

I first did this work in zfsonlinux and SmartOS. This should bring zfsonlinux, SmartOS, and illumos in sync.

https://github.com/zfsonlinux/zfs/commit/d45d7f08fa56f94fc9577a6578cb411071a42e8d

SmartOS, as a private option:

https://github.com/joyent/illumos-joyent/commit/b322ba367cdb75882f1cede5a8b22c7fd17ced94

SmartOS, now public:

https://github.com/joyent/illumos-joyent/commit/d0efab8443fcce33c336a009d253617419db9909

This has been exercised in SmartOS for a couple weeks, with it in the critical path for various bhyve instance operations (create, storage management) without any issues. Testing of the upstreamin work recorded in illumos#11355.

Issues

  • 8
  • 0
  • 0
  • 8
Description From Last Updated
C-style: "Do not nest the ternary conditional operator (?:)." Gergő Mihály Doma Gergő Mihály Doma
C-style: "Do not nest the ternary conditional operator (?:)." Gergő Mihály Doma Gergő Mihály Doma
We had an issue -- 4712 Prefer 'parsable' over 'parseable' in the manual pages -- let's stick to using parsable ... Yuri Pankov Yuri Pankov
(everywhere) use fnvpair family of functions for better readability? Yuri Pankov Yuri Pankov
should be? Yuri Pankov Yuri Pankov
Missing gettext calls? Yuri Pankov Yuri Pankov
Missing gettext calls? Yuri Pankov Yuri Pankov
Missing gettext calls? Yuri Pankov Yuri Pankov
Gergő Mihály Doma
Yuri Pankov
Yuri Pankov
Jerry Jelinek

You might want to close out the open issues, but this looks good to me with the latest changes.

Loading...