11501 Scroll Lock translation to control sequence is patently unhelpful

Review Request #2203 — Created July 28, 2019 and submitted

jclulow
illumos-gate
up/10902
11501
7330cd6...
general
11501 Scroll Lock translation to control sequence is patently unhelpful

See ticket.

  • 1
  • 0
  • 0
  • 0
  • 1
Description From Last Updated
Make this a boolean_t if it's going to be treated as such? pmooney pmooney
yuri.pankov
  1. Ship It!
  2. 
      
citrus
  1. Ship It!
  2. 
      
pmooney
  1. 
      
  2. Make this a boolean_t if it's going to be treated as such?

    1. The intent is for this to be overridden via MDB, and I thought it'd be a bit more obvious that you should use /W and /X if I made it an int.
    2. If the intent is that it should be overriden by mdb then it shouldn't be static. That gives the compiler leeway to inline it as it believes it shouldn't be modified by anything outside the source file.

    3. I did check the program text and test the toggle, but I see your point. Do you want me to remove the static qualifier from the other variables above this one, too? They're called out as being for debugger "tweeking" also.

    4. There is this issue that static or not static does not seem to affect "visibility" of variables for mdb. I think it should be considered bug:)

    5. When most of this code was written compilers would never inline globals that were considered statics. Now, some compilers will. There have been many cases when transitioning from studio to gcc4 that the compiler would opt to inline the variable instead. I disagree about mdb -- if a variable is in a symbol table, mdb should be able to tell you that regardless of whether it's global or local scope. If the problem is disambiguation and knowing which one that refers to in a multi-module system, that's something we should improve. When you're debugging you still want to be able to see what a symbol's value is.
    6. Yes, thats what I meant.

  3. 
      
tsoome
  1. static versus non static, but shipit.

  2. 
      
pmooney
  1. Ship It!
  2. 
      
jclulow
tsoome
  1. Ship It!
  2. 
      
jclulow
  1. Patrick, Andy, Robert, Yuri: are you OK with the last version?
  2. 
      
citrus
  1. Ship It!
  2. 
      
pmooney
  1. Ship It!
  2. 
      
jclulow
Review request changed

Status: Closed (submitted)

Loading...