11493 aggr needs support for multiple pseudo rx groups

Review Request #2201 — Created July 23, 2019 and discarded March 16, 2020, 3:24 p.m.

Information
Owner:	rm
Repository:	illumos-gate
Branch:	master
Bugs:	11493
Depends On:	~~2200~~
Reviewers
Groups:	general
People:

Description

11493 aggr needs support for multiple pseudo rx groups

Portions contributed by: Dan McDonald <danmcd@joyent.com>

Reviewed by: Patrick Mooney <patrick.mooney@joyent.com>

Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>

Reviewed by: Robert Mustacchi <rm@joyent.com>

Testing Done

Issues

2
0
0
0
All Issues: 2

Description	From	Last Updated
Can this just be an else (with no "if") but have ASSERT(rtype == MAC_RING_TYPE_TX) in the "then" clause? I'm suprised ...	pwinder	Jan. 20, 2020, 12:59 p.m.
For consistency with other checks can this be: if ((mcip->mci_state_flags & MCIS_IS_AGGR_PORT) != 0) {	pwinder	Jan. 20, 2020, 12:59 p.m.

Fix it!

usr/src/cmd/mdb/common/modules/mac/mac.c (Diff revision 1)

This will have to change now!
pbchk will catch this and any others

rzezeski Jan. 22, 2020, 11:03 p.m.

Hey Paul, thanks for taking a look at this. I moved this review over to gerritt.

https://code.illumos.org/c/illumos-gate/+/336

If you could re-apply your comments there that would be great. Though, I plan to leave the copyrights alone since they accurately reflect when the code was written (with the exception of any code I update, of course).

usr/src/uts/common/io/mac/mac.c (Diff revision 1)

Show all issues

Can this just be an else (with no "if") but have
ASSERT(rtype == MAC_RING_TYPE_TX)

in the "then" clause? I'm suprised the compiler hasn't moaned about "grp" maybe used uninitialized.

usr/src/uts/common/io/mac/mac_datapath_setup.c (Diff revision 1)

Show all issues

For consistency with other checks can this be:
if ((mcip->mci_state_flags & MCIS_IS_AGGR_PORT) != 0) {

You have a pending review.

Review Board 3.0.18

11493 aggr needs support for multiple pseudo rx groups

Status: Discarded