11493 aggr needs support for multiple pseudo rx groups

Review Request #2201 - Created July 23, 2019 and updated

Information
Robert Mustacchi
illumos-gate
master
11493
2200
f72bb0d...
Reviewers
general

11493 aggr needs support for multiple pseudo rx groups
Portions contributed by: Dan McDonald <danmcd@joyent.com>
Reviewed by: Patrick Mooney <patrick.mooney@joyent.com>
Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
Reviewed by: Robert Mustacchi <rm@joyent.com>


  

Issues

  • 2
  • 0
  • 0
  • 2
Description From Last Updated
Can this just be an else (with no "if") but have ASSERT(rtype == MAC_RING_TYPE_TX) in the "then" clause? I'm suprised ... Paul Winder Paul Winder
For consistency with other checks can this be: if ((mcip->mci_state_flags & MCIS_IS_AGGR_PORT) != 0) { Paul Winder Paul Winder
Paul Winder

   

This will have to change now!
pbchk will catch this and any others

  1. Hey Paul, thanks for taking a look at this. I moved this review over to gerritt.

    https://code.illumos.org/c/illumos-gate/+/336

    If you could re-apply your comments there that would be great. Though, I plan to leave the copyrights alone since they accurately reflect when the code was written (with the exception of any code I update, of course).

usr/src/uts/common/io/mac/mac.c (Diff revision 1)
 
 

Can this just be an else (with no "if") but have

ASSERT(rtype == MAC_RING_TYPE_TX)

in the "then" clause? I'm suprised the compiler hasn't moaned about "grp" maybe used uninitialized.

For consistency with other checks can this be:

if ((mcip->mci_state_flags & MCIS_IS_AGGR_PORT) != 0) {
Loading...