11475 gptzfsboot: update parsing the option switches

Review Request #2186 — Created July 16, 2019 and submitted

tsoome
illumos-gate
11475
4c9df72...
general

11475 gptzfsboot: update parsing the option switches



  • 0
  • 0
  • 1
  • 1
  • 2
Description From Last Updated
rm
  1. 
      
  2. usr/src/boot/sys/boot/i386/gptzfsboot/zfsboot.c (Diff revision 1)
     
     
     
     
     
     
     
     
    If we have an invalid conversion, shouldn't we warn/error about that?
    1. We can yes. However, it should be noted that in case when the current console is not accessible (like bhyve case), there is no way to see the message. But then again, there is nothing we can really do about it.

  3. 
      
tsoome
tsoome
tsoome
tsoome
citrus
  1. Ship It!
  2. 
      
rm
  1. 
      
  2. I'm trying to figure out why we dno't need to set the serial option here. If we don't, how will we ever hit the if statement to set ioctrl below to IO_SERIAL?
    1. that did confuse me too:) but the logic is, serial console is set by either -D (double console) or by -h . -Sxxx will only set the speed. Therefore, to switch to 9600 serial, it would be enough to use -h, but to change the speed to 19200, -h -S19200 would be needed. this is traditional fbsd behavior - so far we have kept it as is.

    2. Ah, OK. I guess no one ever set things up such that that was the case with our usage.
  3. usr/src/man/man5/gptzfsboot.5 (Diff revision 3)
     
     
    Should we clean up the whitespace?
  4. 
      
tsoome
rm
  1. Ship It!
  2. 
      
tsoome
Review request changed

Status: Closed (submitted)

Loading...