usr/src/boot/sys/boot/i386/gptzfsboot/zfsboot.c (Diff revision 1)

Show all issues

If we have an invalid conversion, shouldn't we warn/error about that?

1. 

   Toomas Soome July 17, 2019, 5:50 a.m.

   We can yes. However, it should be noted that in case when the current console is not accessible (like bhyve case), there is no way to see the message. But then again, there is nothing we can really do about it.

Ship It!

usr/src/boot/sys/boot/i386/gptzfsboot/zfsboot.c (Diff revisions 1 - 3)

Show all issues

I'm trying to figure out why we dno't need to set the serial option here. If we don't, how will we ever hit the if statement to set ioctrl below to IO_SERIAL?

1. 

   Toomas Soome July 18, 2019, 2:21 p.m.

   that did confuse me too:) but the logic is, serial console is set by either -D (double console) or by -h . -Sxxx will only set the speed. Therefore, to switch to 9600 serial, it would be enough to use -h, but to change the speed to 19200, -h -S19200 would be needed. this is traditional fbsd behavior -  so far we have kept it as is.

2. 

   Robert Mustacchi July 19, 2019, 5:01 p.m.

   Ah, OK. I guess no one ever set things up such that that was the case with our usage.

usr/src/man/man5/gptzfsboot.5 (Diff revision 3)

Should we clean up the whitespace?

1. 

   Toomas Soome Aug. 7, 2019, 3:49 p.m.

   Fixed.

Ship It!