- Download Diff

Summary:

11470 vioblk: device capacity is always returned in 512B units

Review Request #2183 — Created July 15, 2019 and submitted Aug. 20, 2019, 11:24 a.m.

Information
Owner:	tsoome
Repository:	illumos-gate
Branch:
Bugs:	11470
Depends On:	~~2180~~
Commit:	50e47a3...
Reviewers
Groups:	general
People:

Description

11470 vioblk: device capacity is always returned in 512B units

Testing Done

Issues

0
0
1
0
All Issues: 1

Description	From	Last Updated
Should there be a guard against divison by zero?	seeemef@mac.com	July 15, 2019, 8:54 p.m.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Ship it!

Ship It!

hans July 15, 2019, 1:57 p.m.

I think this and 11471 should be one single commit.

usr/src/uts/common/io/vioblk/vioblk.c (Diff revision 1)

Show all issues

Should there be a guard against divison by zero?

tsoome July 15, 2019, 4:29 p.m.

we do set the value in attach() entry point...

seeemef@mac.com July 15, 2019, 7:37 p.m.

I wondered if there were a possibility of setting sc_blk_size to zero at line 917 and then dividing by that here.

Commit:

-	be32c81151edb83417c8e49f921f884356bc0cb9
+	b0b0be31f7b3cccfc16da3b2b913aab5e7c6855a

Diff:

Revision 2 (+10 -4)

Show changes

usr/src/uts/common/io/vioblk/vioblk.c

Ship it!

```
LGTM
```

Change Summary:

rebase on 11329.

Commit:

-	b0b0be31f7b3cccfc16da3b2b913aab5e7c6855a
+	39c6abfc470bf3ccf743df930f5c690833a008b4

Diff:

Revision 3 (+6)

Show changes

usr/src/uts/common/io/vioblk/vioblk.c

Commit:

-	39c6abfc470bf3ccf743df930f5c690833a008b4
+	50e47a39af7d34f6aef58773b5ab89e871b39f2f

Diff:

Revision 4 (+6)

Show changes

usr/src/uts/common/io/vioblk/vioblk.c

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

You have a pending review.

Review Board 3.0.18

11470 vioblk: device capacity is always returned in 512B units

Commit:

Diff:

Change Summary:

Commit:

Diff:

Commit:

Diff:

Status: Closed (submitted)