11437 uadmin: NULL pointer errors

Review Request #2155 - Created July 11, 2019 and updated

Information
Toomas Soome
illumos-gate
11437
84fd99b...
Reviewers
general
In file included from /code/illumos-gate/proto/root_i386/usr/include/iso/time_iso.h:49:0,
                 from /code/illumos-gate/proto/root_i386/usr/include/time.h:40,
                 from /code/illumos-gate/proto/root_i386/usr/include/sys/time.h:462,
                 from /code/illumos-gate/proto/root_i386/usr/include/sys/select.h:53,
                 from /code/illumos-gate/proto/root_i386/usr/include/sys/types.h:640,
                 from /code/illumos-gate/proto/root_i386/usr/include/fcntl.h:39,
                 from uadmin.c:31:
uadmin.c: In function 'main':
/code/illumos-gate/proto/root_i386/usr/include/sys/null.h:28:14: error: initialization makes integer from pointer without a cast [-Werror=int-conversion]
 #define NULL ((void *)0)
              ^
uadmin.c:63:19: note: in expansion of macro 'NULL'
  uintptr_t mdep = NULL;
                   ^~~~
uadmin.c:155:8: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
   mdep = NULL; /* Ignore all arguments */
        ^
uadmin.c:163:8: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
   mdep = NULL; /* Ignore all arguments */
        ^
In file included from /code/illumos-gate/proto/root_i386/usr/include/iso/time_iso.h:49:0,
                 from /code/illumos-gate/proto/root_i386/usr/include/time.h:40,
                 from /code/illumos-gate/proto/root_i386/usr/include/sys/time.h:462,
                 from /code/illumos-gate/proto/root_i386/usr/include/sys/select.h:53,
                 from /code/illumos-gate/proto/root_i386/usr/include/sys/types.h:640,
                 from /code/illumos-gate/proto/root_i386/usr/include/fcntl.h:39,
                 from uadmin.c:31:
uadmin.c: In function 'wait_for_auqueue':
/code/illumos-gate/proto/root_i386/usr/include/sys/null.h:28:14: error: passing argument 3 of 'auditon' makes integer from pointer without a cast [-Werror=int-conversion]
 #define NULL ((void *)0)
              ^
uadmin.c:438:60: note: in expansion of macro 'NULL'
  while (retries-- && auditon(A_GETSTAT, (caddr_t)&au_stat, NULL) == 0) {
                                                            ^~~~
In file included from /code/illumos-gate/proto/root_i386/usr/include/bsm/adt.h:34:0,
                 from uadmin.c:42:
/code/illumos-gate/proto/root_i386/usr/include/bsm/libbsm.h:188:12: note: expected 'int' but argument is of type 'void *'
 extern int auditon(int, caddr_t, int);
            ^~~~~~~
cc1: all warnings being treated as errors

  

Issues

  • 0
  • 1
  • 0
  • 1
Description From Last Updated
Andy Fiddaman
Toomas Soome
Review request changed

Commit:

-eac40184d167591145b0c18c905ccd206596f904
+84fd99b2af73d190130cca6fc7d845c77b901165

Diff:

Revision 2 (+5 -5)

Show changes

Andy Fiddaman
Ship It!
Loading...