11434 stmsboot: NULL pointer errors
Review Request #2152 - Created July 11, 2019 and submitted
| Information | |
|---|---|
| Toomas Soome | |
| illumos-gate | |
| 11434, 11510 | |
| 0fa9d19... | |
| Reviewers | |
| general | |
stmsboot_util.c: In function 'parse_args':
stmsboot_util.c:414:36: error: comparison between pointer and integer [-Werror]
if ((strncmp(drvlimit, "fp", 2) == NULL) &&
^~
stmsboot_util.c:415:37: error: comparison between pointer and integer [-Werror]
(strncmp(drvlimit, "mpt", 3) == NULL) &&
^~
stmsboot_util.c:416:41: error: comparison between pointer and integer [-Werror]
(strncmp(drvlimit, "mpt_sas", 7) == NULL) &&
^~
stmsboot_util.c:417:38: error: comparison between pointer and integer [-Werror]
(strncmp(drvlimit, "pmcs", 4) == NULL)) {
^~
cc1: all warnings being treated as errors
Andy Fiddaman
Ship It!
Review request changed
Change Summary:
add fix for 11510
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+7 -7) |
-
usr/src/cmd/stmsboot/stmsboot_util.c (Diff revision 2) -
Any idea why the original code just checked the prefix?
Since you're changing this, I'd remove the unecessary brackets.
Review request changed
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 3 (+7 -7) |
Ship It!
Ship It!
Ship It!
Review request changed
Change Summary:
smatch error: unchecked function return 'strlcpy'. It actually makes sense to check the return value there.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 4 (+13 -7) |