11431 sort: NULL pointer errors

Review Request #2149 — Created July 11, 2019 and submitted July 23, 2019, 5:33 a.m.

Information
Owner:	tsoome
Repository:	illumos-gate
Branch:
Bugs:	11431
Depends On:
Commit:	7042080...
Reviewers
Groups:	general
People:

Description

In file included from /code/illumos-gate/proto/root_i386/usr/include/iso/time_iso.h:49:0,
                 from /code/illumos-gate/proto/root_i386/usr/include/time.h:40,
                 from /code/illumos-gate/proto/root_i386/usr/include/sys/time.h:462,
                 from /code/illumos-gate/proto/root_i386/usr/include/sys/select.h:53,
                 from /code/illumos-gate/proto/root_i386/usr/include/sys/types.h:640,
                 from /code/illumos-gate/proto/root_i386/usr/include/sys/mman.h:54,
                 from ../common/utility.h:36,
                 from ../common/utility.c:29:
../common/utility.c: In function 'wxwrite':
/code/illumos-gate/proto/root_i386/usr/include/sys/null.h:28:14: error: passing argument 1 of 'cxwrite' makes integer from pointer without a cast [-Werror=int-conversion]
 #define NULL ((void *)0)
              ^
../common/utility.c:559:19: note: in expansion of macro 'NULL'
   return (cxwrite(NULL, 0, 1));
                   ^~~~
../common/utility.c:494:1: note: expected 'int' but argument is of type 'void *'
 cxwrite(int fd, char *ptr, size_t nbytes)
 ^~~~~~~
cc1: all warnings being treated as errors

Testing Done

Issues

0
0
1
0
All Issues: 1

Description	From	Last Updated
Just weird.. int cxwrite(int fd, char *ptr, size_t nbytes) { ... write(fd, buffer, offset) I have no idea what the ...	citrus	July 17, 2019, 5:48 p.m.

usr/src/cmd/sort/common/utility.c (Diff revision 1)

Show all issues

Just weird..

int
cxwrite(int fd, char *ptr, size_t nbytes)
{
    ...
    write(fd, buffer, offset)


I have no idea what the new line should look like.

The second argument should most likely be NULL rather than 0, but then why 1 byte for the last argument?

Writing to STDIN makes little sense..
return (cxwrite(FILENO_STDOUT, NULL, 0)); ? Your guess is as good as mine!

tsoome July 17, 2019, 5:48 p.m.

first one should of course be fd and nbytes can be anything. The reason is, wxwrite() is implementing the multibyte version of cxwrite(); cxwrite() does flush the static buffer when called with ptr == NULL, and while flushing, it is ignoring nbytes because it only needs to write internal buffer.
So the correct call is cxwrite(fd, NULL, 0).

Commit:

-	cb697186f79d9f72146d351bca52f30a78c699b0
+	7042080708efbe09c12c438b5183cf6c76bccfa0

Diff:

Revision 2 (+1 -3)

Show changes

usr/src/cmd/sort/common/utility.c

Ship it!

```
Ship It!
```

You have a pending review.

Review Board 3.0.18

11431 sort: NULL pointer errors

Commit:

Diff:

Status: Closed (submitted)