11430 smbsrv: NULL pointer errors

Reviews
Diff

- Download Diff

Information
Submitter:	Toomas Soome
Repository:	illumos-gate
Branch:
Bugs:	11430
Depends On:
Commit:	735836a...
Reviewers
Groups:	general
People:

Description

smbd_doorsvc.c: In function 'smbd_dop_vss_map_gmttoken':
smbd_doorsvc.c:805:10: error: return makes integer from pointer without a cast [-Werror=int-conversion]
   return (NULL);
          ^
cc1: all warnings being treated as errors

Testing Done

Issues

0
1
0
All Issues: 1

Description	From	Last Updated
SMB_DOP_SUCCESS? That's defined to 0 but this feels more like it should be SMB_DOP_DECODE_ERROR	Andy Fiddaman	July 17, 2019, 5:13 p.m.

usr/src/cmd/smbsrv/smbd/smbd_doorsvc.c (Diff revision 1)

Show all issues

SMB_DOP_SUCCESS? That's defined to 0 but this feels more like it should be SMB_DOP_DECODE_ERROR

Toomas Soome July 17, 2019, 5:13 p.m.

SMB_DOP_ENCODE_ERROR, because we did attempt to allocate space for encode.

Commit:

-	3a5c15b6d64cc5f834781b50542bce4ed0e16bac
+	735836a81986e2eafa9154b76c1679bfe36652ff

Diff:

Revision 2 (+1 -1)

Show changes

usr/src/cmd/smbsrv/smbd/smbd_doorsvc.c

Ship it!

Ship It!

You have a pending review.

Review Board 2.5.16

Screenshots

Files

Issues

Commit:

Diff:

Status: Closed (submitted)