11430 smbsrv: NULL pointer errors

Review Request #2148 — Created July 11, 2019 and submitted

tsoome
illumos-gate
11430
735836a...
general
smbd_doorsvc.c: In function 'smbd_dop_vss_map_gmttoken':
smbd_doorsvc.c:805:10: error: return makes integer from pointer without a cast [-Werror=int-conversion]
   return (NULL);
          ^
cc1: all warnings being treated as errors


  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
citrus
  1. 
      
  2. usr/src/cmd/smbsrv/smbd/smbd_doorsvc.c (Diff revision 1)
     
     

    SMB_DOP_SUCCESS? That's defined to 0 but this feels more like it should be SMB_DOP_DECODE_ERROR

    1. SMB_DOP_ENCODE_ERROR, because we did attempt to allocate space for encode.

  3. 
      
tsoome
citrus
  1. Ship It!
  2. 
      
tsoome
Review request changed

Status: Closed (submitted)

Loading...