11415 rcap: NULL pointer errors

Review Request #2136 - Created July 11, 2019 and updated

Information
Toomas Soome
illumos-gate
11415
b0625e5...
Reviewers
general
rcapd_scanner.c: In function 'advance_prpageheader_cur_nextmapping':
rcapd_scanner.c:246:10: error: return makes integer from pointer without a cast [-Werror=int-conversion]
   return (NULL);
          ^
rcapd_scanner.c: In function 'OR_pagedata':
rcapd_scanner.c:432:18: error: comparison between pointer and integer [-Werror]
  while (src_addr != NULL && dst_addr != NULL) {
                  ^~
rcapd_scanner.c:432:38: error: comparison between pointer and integer [-Werror]
  while (src_addr != NULL && dst_addr != NULL) {
                                      ^~
rcapd_scanner.c:433:43: error: comparison between pointer and integer [-Werror]
   while (src_addr == dst_addr && src_addr != NULL) {
                                           ^~
rcapd_scanner.c:445:43: error: comparison between pointer and integer [-Werror]
   while (src_addr != dst_addr && src_addr != NULL && dst_addr !=
                                           ^~
rcapd_scanner.c:445:63: error: comparison between pointer and integer [-Werror]
   while (src_addr != dst_addr && src_addr != NULL && dst_addr !=
                                                               ^~
In file included from /code/illumos-gate/proto/root_i386/usr/include/iso/time_iso.h:49:0,
                 from /code/illumos-gate/proto/root_i386/usr/include/time.h:40,
                 from /code/illumos-gate/proto/root_i386/usr/include/sys/time.h:462,
                 from /code/illumos-gate/proto/root_i386/usr/include/sys/select.h:53,
                 from /code/illumos-gate/proto/root_i386/usr/include/sys/types.h:640,
                 from /code/illumos-gate/proto/root_i386/usr/include/sys/mman.h:54,
                 from rcapd_scanner.c:28:
rcapd_scanner.c: In function 'scan_abort':
/code/illumos-gate/proto/root_i386/usr/include/sys/null.h:28:14: error: passing argument 2 of 'Prelease' makes integer from pointer without a cast [-Werror=int-conversion]
 #define NULL ((void *)0)
              ^
rcapd_scanner.c:994:28: note: in expansion of macro 'NULL'
   (void) Prelease(scan_pr, NULL);
                            ^~~~
In file included from rcapd_scanner.c:35:0:
/code/illumos-gate/proto/root_i386/usr/include/libproc.h:251:13: note: expected 'int' but argument is of type 'void *'
 extern void Prelease(struct ps_prochandle *, int);
             ^~~~~~~~
cc1: all warnings being treated as errors

  

Issues

  • 0
  • 2
  • 0
  • 2
Description From Last Updated
Andy Fiddaman
Toomas Soome
Review request changed

Commit:

-db5a0e0d0f56938e1a4a35e1ef4544ced0258461
+b0625e5f8dae3d766a205bcee2a1f7617cc8d409

Diff:

Revision 2 (+8 -9)

Show changes

Andy Fiddaman
Ship It!
Loading...