11411 pwconv: NULL pointer errors

Review Request #2133 - Created July 11, 2019 and updated

Information
Toomas Soome
illumos-gate
11411
4420108...
Reviewers
general
pwconv.c: In function 'main':
pwconv.c:247:23: error: comparison between pointer and integer [-Werror]
      *pwdp->pw_passwd == NULL)) {
                       ^~
pwconv.c:264:39: error: comparison between pointer and integer [-Werror]
     if (pwdp->pw_age && *pwdp->pw_age != NULL) {
                                       ^~
pwconv.c:311:45: error: comparison between pointer and integer [-Werror]
        (pwdp->pw_passwd && *pwdp->pw_passwd == NULL)) &&
                                             ^~
pwconv.c:323:21: error: comparison between pointer and integer [-Werror]
       *pwdp->pw_age == NULL)) {
                     ^~
pwconv.c:350:38: error: comparison between pointer and integer [-Werror]
    if (pwdp->pw_age && *pwdp->pw_age != NULL) {
                                      ^~
cc1: all warnings being treated as errors

  

Issues

  • 0
  • 4
  • 0
  • 4
Description From Last Updated
Andy Fiddaman
Toomas Soome
Review request changed

Commit:

-ee4ad4efd8dd40abfb681063dc63b241f4e3d727
+4420108e63c5da46babe9e92be973df30ebe1317

Diff:

Revision 2 (+112 -109)

Show changes

Andy Fiddaman
Ship It!
Loading...