11399 nlsadmin: NULL pointer errors

Review Request #2121 - Created July 11, 2019 and submitted

Information
Toomas Soome
illumos-gate
11399
2f311a0...
Reviewers
general
nlsadmin.c: In function 'main':
nlsadmin.c:359:10: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
    *ptr2 = NULL;
          ^
nlsadmin.c: In function 'prt_cmd':
nlsadmin.c:558:8: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
   *tmp = NULL;
        ^
nlsadmin.c: In function 'old_addsvc':
nlsadmin.c:603:8: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
   *tmp = NULL;
        ^
nlsadmin.c: In function 'prt_nets':
nlsadmin.c:696:32: error: comparison between pointer and integer [-Werror]
   if (strcmp(state, "ENABLED") == NULL ||
                                ^~
nlsadmin.c:697:33: error: comparison between pointer and integer [-Werror]
       strcmp(state, "STARTING") == NULL) {
                                 ^~
nlsadmin.c: In function 'svc_format':
nlsadmin.c:1251:9: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
  *ptr++ = NULL;
         ^
nlsadmin.c:1255:9: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
  *ptr++ = NULL;
         ^
nlsadmin.c:1263:9: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
  *ptr++ = NULL;
         ^
nlsadmin.c:1267:9: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
  *ptr++ = NULL;
         ^
nlsadmin.c:1271:9: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
  *ptr++ = NULL;
         ^
nlsadmin.c:1275:9: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
  *ptr++ = NULL;
         ^
nlsadmin.c:1279:9: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
  *ptr++ = NULL;
         ^
nlsadmin.c:1283:9: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
  *ptr++ = NULL;
         ^
nlsadmin.c:1287:9: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
  *ptr++ = NULL;
         ^
nlsadmin.c:1291:9: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
  *ptr++ = NULL;
         ^
nlsadmin.c:1300:9: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
  *ptr++ = NULL;
         ^
nlsadmin.c:1304:9: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
  *ptr++ = NULL;
         ^
nlsadmin.c:1308:9: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
  *ptr++ = NULL;
         ^
cc1: all warnings being treated as errors

  
Andy Fiddaman
Toomas Soome
Review request changed

Status: Closed (submitted)

Loading...