11385 ls: NULL pointer errors

Review Request #2108 — Created July 10, 2019 and submitted July 16, 2019, 6:30 a.m.

Information
Owner:	tsoome
Repository:	illumos-gate
Branch:
Bugs:	11385
Depends On:
Commit:	37f9d87...
Reviewers
Groups:	general
People:

Description

../ls.c: In function 'set_sysattrtm_display':
../ls.c:2540:14: error: comparison between pointer and integer [-Werror]
   if (*value != NULL) {
              ^~
cc1: all warnings being treated as errors

Testing Done

Issues

0
0
1
0
All Issues: 1

Description	From	Last Updated
Should it be value != NULL or do we really mean value[0] != 0 ?	alp	July 10, 2019, 5:41 p.m.

usr/src/cmd/ls/ls.c (Diff revision 1)

Show all issues

Should it be value  != NULL or do we really mean value[0] != 0 ?

tsoome July 10, 2019, 5:42 p.m.

actually it has to be value != NULL because we can get NULL when array length is 0.

Ship it!

```
Ship It!
```

Commit:

-	4c516f2df8822d3f78b20c8006d9ed61b0bc030f
+	37f9d8702ab862b490bb862c0e1e0def46eb8d24

Diff:

Revision 2 (+5 -5)

Show changes

usr/src/cmd/ls/ls.c

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

You have a pending review.

Review Board 3.0.18

11385 ls: NULL pointer errors

Commit:

Diff:

Status: Closed (submitted)