7223 grub "setup" built-in broken by 6593

Review Request #209 — Created July 25, 2016 and submitted

jclulow
illumos-gate
7223
general

As per description in bug: https://www.illumos.org/issues/7223

As per description in bug.

  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
jclulow
richlowe
  1. Ship It!
  2. 
      
rm
  1. In general, looks okay; however, there seems to be some inconsistency in the embed_func argument type and the start_sector size.

  2. So this is sized as a unsigned long long; however, it seems like the contents of stage2/filesys.h haven't changed, which is of type int *.
  3. 
      
tsoome
  1. Ship It!
  2. 
      
jclulow
tsoome
  1. Ship It!
  2. 
      
rm
  1. Ship It!
  2. 
      
kmays
  1. Ship It!
  2. 
      
jclulow
Review request changed

Status: Closed (submitted)

Loading...