11337 geniconvtbl: NULL pointer errors

Review Request #2073 — Created July 6, 2019 and submitted

tsoome
illumos-gate
11337
e943db8...
general
../geniconvtbl.c: In function 'eval_cond_tbl':
../geniconvtbl.c:1000:13: error: comparison between pointer and integer [-Werror]
    if (NULL == ist->default_action.itm_ptr) {
             ^~
cc1: all warnings being treated as errors


andy_js
  1. Ship It!
  2. 
      
gdamore
  1. Ship It!
  2. 
      
ptribble
  1. It's fine, but why flip the order round, so it's now different from similar comparisons in the same file?

    1. I guess it was kind of automatic, fixed.

    2. I actually find comparing NULL or constants before the comparand to be less readable. I am fine with it either way.

  2. 
      
tsoome
ptribble
  1. Ship It!
  2. 
      
tsoome
Review request changed

Status: Closed (submitted)

Loading...