7139 Sync mDNS with mDNSResponder-625.41.2

Review Request #201 — Created June 22, 2016 and submitted

Information
tsoome
illumos-gate
7139
Reviewers
general 
7139 Sync mDNS with mDNSResponder-625.41.2
checked address registration events with dns-sd -G v4v6 name.local

getent ipnodes name.local
  • 0
  • 0
  • 0
  • 2
  • 2
Description From Last Updated
tsoome
tsoome
tsoome
danmcd
danmcd 
  1. 
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 

   
    
    
    



    
 
    
  
    
   
   
    
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    Wow!  Does any original-by-us code use this macro? It could be a dangling-else problem.  If not, close this as not-an-issue and just shake your head.
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      no, we dont use it, its only there in uDNS.c and mDNS.c and no "else" issue. Ugly but well - don't really want to make future imports harder than they already are.
      
 
      

      2. 


 
    


    

 
    

    3. 






  3. 
 
    
  
  
    
  
 

   
    
    
    




    
    Wow.  I understand it's rare, but what an asshole thing to say.
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 






  4. 
 
    
  
  
    
  
 

   
    
    
    



    
 
    
  
    
   
   
    
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    Have you tried this on SmartOS, which implements REUSEPORT for LX zones (and as a side-effect, native illumos as well)?
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      Since we do have SO_REUSEADDR, it will be used and SO_REUSEPORT does not get into the game at all. SO_REUSEPORT is only used if SO_REUSEADDR is not defined... So as long as we do have SO_REUSEADDR and we are not announcing ourselves osx, we are fine.
      

      However, if/when SO_REUSEPORT will really be available in illumos, we may want to investigate the use cases. So, in that light, it seems to me, there should not be an issue.
      
 
      

      2. 


 
    


    

 
    

    5. 






  5. 
 
    
  
  
    
  
 

   
    
    
    




    
    I agree with this one, however.
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      And fortunately it's OSX specific code (protected by #if APPLE_OSX_mDNSResponder guard above), so don't really pay too much attention there;)
      
 
      

      2. 


 
    


    

 
    

    6. 




  6. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    7. 




  

 
















 





 

  

   




danmcd




   

   







  

 



 

  


   

   

    
 
danmcd


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   




tsoome




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  






 

  Status:
  

  Closed (submitted)

  
 







 


 










  

 









     

    

   

  

  

   
   Loading...