11084 clean up file-backed l2arc support

Review Request #2008 — Created June 18, 2019 and submitted

Information
kkantor
illumos-gate
reviewboard
92656bd...
Reviewers
general 
11084 clean up file-backed l2arc support


ZoL removed the arbitrary restriction on using files to back l2arc in their MMP commit (379ca9cf2), which Jerry ported to illumos for us. We have a test case that makes sure file-backed l2arc devices can't be created, and libzfs code that handles an error response from the kernel, which no longer occurs. Since we're allowing file-backed l2arc now we should clean this up.
zfs-test run (no new failures)
  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
kkantor
kkantor
igork
igork 
  1. Ship It!
  2. 
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 





 

  

   




tsoome




   

   







  

 



 

  


   

   

    
 
tsoome


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 





 

  

   




jjelinek




   

   







  

 



 

  


   

   

    
 
jjelinek


    
   


  

  

  



    




  1. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 

   
    
    
    



    
 
    
  
    
   
   
    
    
     
     
     
     
     
    
    Show all issues
   
  
    
 
    

    



    
    Should we keep this test but change this to a log_must?
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      Good idea! Unfortunately this isn't as easy as flipping that test statement. If this particular line passes then the next pool creation step fails due to the flat files being in use by another pool. I have the tests creating a separate flat file just for this test case now. Let me know how that looks.
      
 
      

      2. 


 
    


    

 
    

    3. 




  3. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  

 
















 



 

  

   




kkantor




   

   

  

 



 















 





 

  

   




jjelinek




   

   







  

 



 

  


   

   

    
 
jjelinek


    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   




kkantor




   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  






 

  Status:
  

  Closed (submitted)

  
 







 


 










  

 









     

    

   

  

  

   
   Loading...