11208 add mdb format character for jazzed-up binary output

Review Request #1977 — Created June 6, 2019 and submitted July 8, 2019, 2:43 p.m.

Information
Owner:	rm
Repository:	illumos-gate
Branch:	master
Bugs:	11208
Depends On:
Commit:	bd70c7e...
Reviewers
Groups:	general
People:

Description

11208 add mdb format character for jazzed-up binary output
11206 mdb output autowrapping still subtly wrong
11207 many 64-bit mdb format characters have insufficient width
Reviewed by: Robert Mustacchi <rm@joyent.com>
Reviewed by: Jordan Hendricks <jordan.hendricks@joyent.com>

Testing Done

Issues

0
0
0
1
All Issues: 1

Description	From	Last Updated
just curious, why not to use something like highbit() or fls()?	tsoome	June 6, 2019, 5:04 p.m.

usr/src/cmd/mdb/common/mdb/mdb_fmt.c (Diff revision 1)

Show all issues

just curious, why not to use something like highbit() or fls()?

rm June 6, 2019, 4:57 p.m.

When I mentioned it to Bryan originally we discussed how flsll wasn't in kmdb's libstand which made it harder to use and that in this case it didn't help much.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

You have a pending review.

Review Board 3.0.18

11208 add mdb format character for jazzed-up binary output

Status: Closed (submitted)