11208 add mdb format character for jazzed-up binary output

Review Request #1977 - Created June 6, 2019 and updated

Information
Robert Mustacchi
illumos-gate
master
11208
bd70c7e...
Reviewers
general

11208 add mdb format character for jazzed-up binary output
11206 mdb output autowrapping still subtly wrong
11207 many 64-bit mdb format characters have insufficient width
Reviewed by: Robert Mustacchi <rm@joyent.com>
Reviewed by: Jordan Hendricks <jordan.hendricks@joyent.com>


  

Issues

  • 0
  • 0
  • 1
  • 1
Description From Last Updated
Toomas Soome

   
usr/src/cmd/mdb/common/mdb/mdb_fmt.c (Diff revision 1)
 
 

just curious, why not to use something like highbit() or fls()?

  1. When I mentioned it to Bryan originally we discussed how flsll wasn't in kmdb's libstand which made it harder to use and that in this case it didn't help much.

Toomas Soome
Ship It!
Andy Fiddaman
Ship It!
Loading...