11047 zmod: make sure we use zmemcpy and friends

Review Request #1976 — Created June 6, 2019 and submitted

tsoome
illumos-gate
11047
c2bab08...
general
11047 zmod: make sure we use zmemcpy and friends


xvoid
  1. 
      
  2. usr/src/contrib/zlib/zutil.c (Diff revision 1)
     
     

    I wonder if it's possible to do without modifying the source (i.e. by passing the defines in the Makefile), and if not, how this change should be documented so that it's not lost when upgrading contributed zlib code?

    1. The only way to skip modification is to have usable memcpy etc functions in unix; but this update is not a problem because we have zlib in github illumos/zlib repo just for this reason (all usr/src/contrib is intended to have external repo to aid the vendor merges, currently it is about mdns and zlib). For quick fix, I'd go with this patch and once we have usable memcpy, we can drop this, remove zmod_subr.c implementations and use HAVE_MEMCPY knob.

  3. 
      
citrus
  1. Ship It!
  2. 
      
domag02
  1. Ship It!
  2. 
      
tsoome
Review request changed

Status: Closed (submitted)

Loading...