11184 Want CPU Temperature Sensors

Review Request #1963 — Created June 3, 2019 and submitted

rm
illumos-gate
master
11184
a188301...
general

11184 Want CPU Temperature Sensors
11185 i86pc chip module should be smatch clean
Reviewed by: Hans Rosenfeld <hans.rosenfeld@joyent.com>
Reviewed by: Jordan Hendricks <jordan.hendricks@joyent.com>
Reviewed by: Patrick Mooney <patrick.mooney@joyent.com>



  • 0
  • 0
  • 3
  • 0
  • 3
Description From Last Updated
tsoome
  1. 
      
  2. add space before ?

  3. 
      
rm
tsoome
  1. Ship It!
  2. 
      
ptribble
  1. 
      
  2. usr/src/man/man7d/Makefile (Diff revision 2)
     
     

    This ought to be moved down to i386_MANFILES, should it not? Likewise for coretemp.

    1. Yes, it should. Good catch.
  3. 
      
rm
tsoome
  1. Ship It!
  2. 
      
ptribble
  1. 
      
  2. usr/src/uts/common/sys/Makefile (Diff revision 3)
     
     

    I think presence here indicates we install it regardless, yet we only package it on x86. So presumably we either need to install it conditionally, or add it to the exception list so sparc doesn't complain when it ends up in the proto area.

    1. That's a good point. It'd be really useful if there was an easier way to deal with SPARC and at least build it without having a SPARC system. Right now it's impossible, so I often forget to always think through these issues on that platform. In theory this could be useful on SPARC, but currently no common drivers use it. I guess I can just toss it in the exception list?

    2. Yes, I think exception list it.

  3. 
      
rm
ptribble
  1. Ship It!
  2. 
      
tsoome
  1. Ship It!
  2. 
      
rm
Review request changed

Status: Closed (submitted)

Loading...