11174 new driver for Smart Array storage controllers

Review Request #1960 - Created June 2, 2019 and updated

Information
Robert Mustacchi
illumos-gate
master
11174
972d6f1...
Reviewers
general

11174 new driver for Smart Array storage controllers
Portions contributed by: Robert Mustacchi <rm@joyent.com>
Reviewed by: Robert Mustacchi <rm@joyent.com>
Reviewed by: Patrick Mooney <patrick.mooney@joyent.com>


  

Issues

  • 0
  • 1
  • 0
  • 1
Description From Last Updated
Marcel Telka
Garrett D'Amore

Modulo a few questions, this looks really really good. I notice that Gen10 devices are not listed -- we're going to try them on some Gen 10 hardware. If it works, we will reply here (I'm cautiously hopeful). I'm also so very very happy to see another SCSAv3 driver. (AFAIK, this is only the second true SCSAv3 driver after pmcs.)

  1. So, the Skylake based systems (I think that's Gen 10 devices) unfortunately require a new driver in theory, which this doesn't suport. Though it's possible the new devices support enough CISS that this would work. At least in other systems a new driver was written to handle them. I'll try and circle back on a few of the things you mentioned in the next couple of days.

DOes this need to be FORCPU? or would FORKERNEL be sufficient? (Probably little difference on x86 hardware.)

Given that, if we find ourselves here, should we emit a warning or notice message?

Is PANIC really appropriate here?

Marcel Telka
Ship It!
Loading...