marcel
-
-
usr/src/uts/common/io/scsi/adapters/smrt/smrt_physical.c (Diff revision 1) The
smrt->smrt_mutexis never held when this function is called, so I suggest to remove this line.
11174 new driver for Smart Array storage controllers
Review Request #1960 — Created June 2, 2019 and updated
| Information | |
|---|---|
| rm | |
| illumos-gate | |
| master | |
| 11174 | |
| 972d6f1... | |
| Reviewers | |
| general | |
11174 new driver for Smart Array storage controllers
Portions contributed by: Robert Mustacchi <rm@joyent.com>
Reviewed by: Robert Mustacchi <rm@joyent.com>
Reviewed by: Patrick Mooney <patrick.mooney@joyent.com>
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+7995 -38) |
-
Modulo a few questions, this looks really really good. I notice that Gen10 devices are not listed -- we're going to try them on some Gen 10 hardware. If it works, we will reply here (I'm cautiously hopeful). I'm also so very very happy to see another SCSAv3 driver. (AFAIK, this is only the second true SCSAv3 driver after pmcs.)
-
usr/src/uts/common/io/scsi/adapters/smrt/smrt_ciss.c (Diff revision 2) DOes this need to be FORCPU? or would FORKERNEL be sufficient? (Probably little difference on x86 hardware.)
-
usr/src/uts/common/io/scsi/adapters/smrt/smrt_interrupts.c (Diff revision 2) Given that, if we find ourselves here, should we emit a warning or notice message?
-
usr/src/uts/common/io/scsi/adapters/smrt/smrt_physical.c (Diff revision 2) Is PANIC really appropriate here?