11169 nsswitch: NULL pointer errors

Review Request #1954 - Created June 1, 2019 and submitted

Information
Toomas Soome
illumos-gate
11169
ff12952...
Reviewers
general
../common/mdns_common.c
../common/mdns_common.c: In function '_nss_mdns_queryrecord':
../common/mdns_common.c:94:42: error: comparison between pointer and integer [-Werror]
      (sockfd = DNSServiceRefSockFD(ref)) == NULL) {
                                          ^~

../common/getprinter.c: In function '_nss_user_printers_convert':
../common/getprinter.c:50:10: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
   *value = NULL; value++;
          ^
../common/getprinter.c:52:18: error: comparison between pointer and integer [-Werror]
   while ((*value != NULL) && (isspace(*value) != 0))
                  ^~
../common/getprinter.c:56:9: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
    *key = NULL;
         ^
../common/getprinter.c:59:22: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
  args->buf.buffer[0] = NULL;
                      ^
../common/getprinter.c:60:33: error: comparison between pointer and integer [-Werror]
  if ((value == NULL) || (*value == NULL)) { /* bad value */
                                 ^~
../common/getprinter.c:74:48: error: comparison between pointer and integer [-Werror]
  while ((length < args->buf.buflen) && (*value != NULL)) {
                                                ^~
../common/getprinter.c:85:27: error: assignment makes integer from pointer without a cast [-Werror=int-conversion]
  args->buf.buffer[length] = NULL; /* terminate, just in case */
                           ^

../common/getkeyent.c: In function '_nss_ldap_key2str':
../common/getkeyent.c:90:53: error: comparison between pointer and integer [-Werror]
   if (strncasecmp(*pkey_array, keytype, keytypelen) == NULL)
                                                     ^~
../common/getkeyent.c:115:53: error: comparison between pointer and integer [-Werror]
   if (strncasecmp(*skey_array, keytype, keytypelen) == NULL)
                                                     ^~

../common/getprinter.c: In function '_nss_ldap_printers2str':
../common/getprinter.c:215:39: error: comparison between pointer and integer [-Werror]
     for (kp = attr->attrvalue[j]; *kp != NULL; kp++)
                                       ^~
../common/getprinter.c: In function 'append_attr':
../common/getprinter.c:262:13: error: comparison between pointer and integer [-Werror]
  while (*cp != NULL) {
             ^~
cc1: all warnings being treated as errors

  
C Fraire
Toomas Soome
Review request changed

Status: Closed (submitted)

Loading...