6993 DEFAULT_TYPE should be probably be removed from pthread.h

Review Request #194 — Created May 25, 2016 and submitted

risto3
illumos-gate
6993
general
6993 DEFAULT_TYPE should be probably be removed from pthread.h

clean build, hdrcheck/cstyle clean

jeffpc
  1. Ship It!
  2. 
      
tsoome
  1. As apparently pthread.h is target for gcc fixincludes, will this change require some sort of flag day?

    1. That's a nice question.

      From what I can see, fixincludes is no longer update pthread.h since

      commit 1e2ea07 (6611808 pthread_once() intializer triggers GCC warning)

      which torched '#ident'

      I wondered as well about a flag day, but since these are not documented in the manpages...
      I guess I considered it was more an inadvertent bug or worse case implementation private
      'subject to change'.

      Unfortunately, this artifact is quite nasty with any c++ program using stock g++
      which defines __EXTENSIONS__ and try to define a type with this name, such as in lucene++.

    2. Yep, I was thinking primarly in context of some combination of old gcc and such... I guess we shall see;)

  2. 
      
risto3
Review request changed

Status: Closed (submitted)

Change Summary:

commit a90d75b828f0c01a350c4ecfc3924fd6456fffaf

Loading...