11144 libpool: NULL pointer errors

Review Request #1929 — Created June 1, 2019 and submitted

tsoome
illumos-gate
11144
3ab96de...
general
../common/pool.c: In function 'pool_put_property':
../common/pool.c:926:10: error: return makes integer from pointer without a cast [-Werror=int-conversion]
   return (NULL);
          ^
../common/pool.c: In function 'pool_rm_property':
../common/pool.c:1106:10: error: return makes integer from pointer without a cast [-Werror=int-conversion]
   return (NULL);
          ^

In file included from /code/illumos-gate/proto/root_i386/usr/include/iso/stdio_iso.h:53:0,
                 from /code/illumos-gate/proto/root_i386/usr/include/stdio.h:82,
                 from ../common/pool.c:30:
../common/pool.c: In function 'pool_base_info':
/code/illumos-gate/proto/root_i386/usr/include/sys/null.h:28:14: error: initialization makes integer from pointer without a cast [-Werror=int-conversion]
 #define NULL ((void *)0)
              ^
../common/pool_internal.h:140:20: note: in expansion of macro 'NULL'
  {POC_INVAL, NULL, NULL }
                    ^~~~
../common/pool.c:336:21: note: in expansion of macro 'POOL_VALUE_INITIALIZER'
  pool_value_t val = POOL_VALUE_INITIALIZER;
                     ^~~~~~~~~~~~~~~~~~~~~~
/code/illumos-gate/proto/root_i386/usr/include/sys/null.h:28:14: note: (near initialization for 'val.pv_u.u')
 #define NULL ((void *)0)
              ^
../common/pool_internal.h:140:20: note: in expansion of macro 'NULL'
  {POC_INVAL, NULL, NULL }
                    ^~~~
../common/pool.c:336:21: note: in expansion of macro 'POOL_VALUE_INITIALIZER'
  pool_value_t val = POOL_VALUE_INITIALIZER;
                     ^~~~~~~~~~~~~~~~~~~~~~
../common/pool.c: In function 'pool_put_property':
../common/pool.c:926:10: error: return makes integer from pointer without a cast [-Werror=int-conversion]
   return (NULL);
          ^
../common/pool.c: In function 'pool_rm_property':
../common/pool.c:1106:10: error: return makes integer from pointer without a cast [-Werror=int-conversion]
   return (NULL);
          ^
In file included from /code/illumos-gate/proto/root_i386/usr/include/iso/stdio_iso.h:53:0,
                 from /code/illumos-gate/proto/root_i386/usr/include/stdio.h:82,
                 from ../common/pool.c:30:
../common/pool.c: In function 'pool_create':
/code/illumos-gate/proto/root_i386/usr/include/sys/null.h:28:14: error: initialization makes integer from pointer without a cast [-Werror=int-conversion]
 #define NULL ((void *)0)
              ^
../common/pool_internal.h:140:20: note: in expansion of macro 'NULL'
  {POC_INVAL, NULL, NULL }
                    ^~~~
../common/pool.c:1167:21: note: in expansion of macro 'POOL_VALUE_INITIALIZER'
  pool_value_t val = POOL_VALUE_INITIALIZER;
                     ^~~~~~~~~~~~~~~~~~~~~~
/code/illumos-gate/proto/root_i386/usr/include/sys/null.h:28:14: note: (near initialization for 'val.pv_u.u')
 #define NULL ((void *)0)
              ^
../common/pool_internal.h:140:20: note: in expansion of macro 'NULL'
  {POC_INVAL, NULL, NULL }
                    ^~~~
../common/pool.c:1167:21: note: in expansion of macro 'POOL_VALUE_INITIALIZER'
  pool_value_t val = POOL_VALUE_INITIALIZER;
                     ^~~~~~~~~~~~~~~~~~~~~~
../common/pool.c: In function 'pool_resource_create':
/code/illumos-gate/proto/root_i386/usr/include/sys/null.h:28:14: error: initialization makes integer from pointer without a cast [-Werror=int-conversion]
 #define NULL ((void *)0)
              ^
../common/pool_internal.h:140:20: note: in expansion of macro 'NULL'
  {POC_INVAL, NULL, NULL }
                    ^~~~
../common/pool.c:1228:21: note: in expansion of macro 'POOL_VALUE_INITIALIZER'
  pool_value_t val = POOL_VALUE_INITIALIZER;
                     ^~~~~~~~~~~~~~~~~~~~~~
/code/illumos-gate/proto/root_i386/usr/include/sys/null.h:28:14: note: (near initialization for 'val.pv_u.u')
 #define NULL ((void *)0)
              ^
../common/pool_internal.h:140:20: note: in expansion of macro 'NULL'
  {POC_INVAL, NULL, NULL }
                    ^~~~
../common/pool.c:1228:21: note: in expansion of macro 'POOL_VALUE_INITIALIZER'
  pool_value_t val = POOL_VALUE_INITIALIZER;
                     ^~~~~~~~~~~~~~~~~~~~~~
../common/pool.c: In function 'pool_component_create':
/code/illumos-gate/proto/root_i386/usr/include/sys/null.h:28:14: error: initialization makes integer from pointer without a cast [-Werror=int-conversion]
 #define NULL ((void *)0)
              ^
../common/pool_internal.h:140:20: note: in expansion of macro 'NULL'
  {POC_INVAL, NULL, NULL }
                    ^~~~
../common/pool.c:1345:21: note: in expansion of macro 'POOL_VALUE_INITIALIZER'
  pool_value_t val = POOL_VALUE_INITIALIZER;
                     ^~~~~~~~~~~~~~~~~~~~~~
/code/illumos-gate/proto/root_i386/usr/include/sys/null.h:28:14: note: (near initialization for 'val.pv_u.u')
 #define NULL ((void *)0)
              ^
../common/pool_internal.h:140:20: note: in expansion of macro 'NULL'
  {POC_INVAL, NULL, NULL }
                    ^~~~
../common/pool.c:1345:21: note: in expansion of macro 'POOL_VALUE_INITIALIZER'
  pool_value_t val = POOL_VALUE_INITIALIZER;
                     ^~~~~~~~~~~~~~~~~~~~~~
../common/pool.c: In function 'pool_walk_any_properties':
/code/illumos-gate/proto/root_i386/usr/include/sys/null.h:28:14: error: initialization makes integer from pointer without a cast [-Werror=int-conversion]
 #define NULL ((void *)0)
              ^
../common/pool_internal.h:140:20: note: in expansion of macro 'NULL'
  {POC_INVAL, NULL, NULL }
                    ^~~~
../common/pool.c:1734:23: note: in expansion of macro 'POOL_VALUE_INITIALIZER'
    pool_value_t val = POOL_VALUE_INITIALIZER;
                       ^~~~~~~~~~~~~~~~~~~~~~
/code/illumos-gate/proto/root_i386/usr/include/sys/null.h:28:14: note: (near initialization for 'val.pv_u.u')
 #define NULL ((void *)0)
              ^
../common/pool_internal.h:140:20: note: in expansion of macro 'NULL'
  {POC_INVAL, NULL, NULL }
                    ^~~~
../common/pool.c:1734:23: note: in expansion of macro 'POOL_VALUE_INITIALIZER'
    pool_value_t val = POOL_VALUE_INITIALIZER;
                       ^~~~~~~~~~~~~~~~~~~~~~
../common/pool.c: In function 'pool_get_pool':
/code/illumos-gate/proto/root_i386/usr/include/sys/null.h:28:14: error: initialization makes integer from pointer without a cast [-Werror=int-conversion]
 #define NULL ((void *)0)
              ^
../common/pool_internal.h:140:20: note: in expansion of macro 'NULL'
  {POC_INVAL, NULL, NULL }
                    ^~~~
../common/pool.c:1824:21: note: in expansion of macro 'POOL_VALUE_INITIALIZER'
  pool_value_t val = POOL_VALUE_INITIALIZER;
                     ^~~~~~~~~~~~~~~~~~~~~~
/code/illumos-gate/proto/root_i386/usr/include/sys/null.h:28:14: note: (near initialization for 'val.pv_u.u')
 #define NULL ((void *)0)
              ^
../common/pool_internal.h:140:20: note: in expansion of macro 'NULL'
  {POC_INVAL, NULL, NULL }
                    ^~~~
../common/pool.c:1824:21: note: in expansion of macro 'POOL_VALUE_INITIALIZER'
  pool_value_t val = POOL_VALUE_INITIALIZER;
                     ^~~~~~~~~~~~~~~~~~~~~~
../common/pool.c: In function 'pool_get_resource':
/code/illumos-gate/proto/root_i386/usr/include/sys/null.h:28:14: error: initialization makes integer from pointer without a cast [-Werror=int-conversion]
 #define NULL ((void *)0)
              ^
../common/pool_internal.h:140:20: note: in expansion of macro 'NULL'
  {POC_INVAL, NULL, NULL }
                    ^~~~
../common/pool.c:1909:22: note: in expansion of macro 'POOL_VALUE_INITIALIZER'
  pool_value_t val0 = POOL_VALUE_INITIALIZER;
                      ^~~~~~~~~~~~~~~~~~~~~~
/code/illumos-gate/proto/root_i386/usr/include/sys/null.h:28:14: note: (near initialization for 'val0.pv_u.u')
 #define NULL ((void *)0)
              ^
../common/pool_internal.h:140:20: note: in expansion of macro 'NULL'
  {POC_INVAL, NULL, NULL }
                    ^~~~
../common/pool.c:1909:22: note: in expansion of macro 'POOL_VALUE_INITIALIZER'
  pool_value_t val0 = POOL_VALUE_INITIALIZER;
                      ^~~~~~~~~~~~~~~~~~~~~~
/code/illumos-gate/proto/root_i386/usr/include/sys/null.h:28:14: error: initialization makes integer from pointer without a cast [-Werror=int-conversion]
 #define NULL ((void *)0)
              ^
../common/pool_internal.h:140:20: note: in expansion of macro 'NULL'
  {POC_INVAL, NULL, NULL }
                    ^~~~
../common/pool.c:1910:22: note: in expansion of macro 'POOL_VALUE_INITIALIZER'
  pool_value_t val1 = POOL_VALUE_INITIALIZER;
                      ^~~~~~~~~~~~~~~~~~~~~~
/code/illumos-gate/proto/root_i386/usr/include/sys/null.h:28:14: note: (near initialization for 'val1.pv_u.u')
 #define NULL ((void *)0)
              ^
../common/pool_internal.h:140:20: note: in expansion of macro 'NULL'
  {POC_INVAL, NULL, NULL }
                    ^~~~
../common/pool.c:1910:22: note: in expansion of macro 'POOL_VALUE_INITIALIZER'
  pool_value_t val1 = POOL_VALUE_INITIALIZER;
                      ^~~~~~~~~~~~~~~~~~~~~~
../common/pool.c: In function 'pool_resource_transfer':
/code/illumos-gate/proto/root_i386/usr/include/sys/null.h:28:14: error: initialization makes integer from pointer without a cast [-Werror=int-conversion]
 #define NULL ((void *)0)
              ^
../common/pool_internal.h:140:20: note: in expansion of macro 'NULL'
  {POC_INVAL, NULL, NULL }
                    ^~~~
../common/pool.c:2398:22: note: in expansion of macro 'POOL_VALUE_INITIALIZER'
   pool_value_t val = POOL_VALUE_INITIALIZER;
                      ^~~~~~~~~~~~~~~~~~~~~~
/code/illumos-gate/proto/root_i386/usr/include/sys/null.h:28:14: note: (near initialization for 'val.pv_u.u')
 #define NULL ((void *)0)
              ^
../common/pool_internal.h:140:20: note: in expansion of macro 'NULL'
  {POC_INVAL, NULL, NULL }
                    ^~~~
../common/pool.c:2398:22: note: in expansion of macro 'POOL_VALUE_INITIALIZER'
   pool_value_t val = POOL_VALUE_INITIALIZER;
                      ^~~~~~~~~~~~~~~~~~~~~~
../common/pool.c: In function 'pool_resource_xtransfer':
/code/illumos-gate/proto/root_i386/usr/include/sys/null.h:28:14: error: initialization makes integer from pointer without a cast [-Werror=int-conversion]
 #define NULL ((void *)0)
              ^
../common/pool_internal.h:140:20: note: in expansion of macro 'NULL'
  {POC_INVAL, NULL, NULL }
                    ^~~~
../common/pool.c:2461:22: note: in expansion of macro 'POOL_VALUE_INITIALIZER'
   pool_value_t val = POOL_VALUE_INITIALIZER;
                      ^~~~~~~~~~~~~~~~~~~~~~
/code/illumos-gate/proto/root_i386/usr/include/sys/null.h:28:14: note: (near initialization for 'val.pv_u.u')
 #define NULL ((void *)0)
              ^
../common/pool_internal.h:140:20: note: in expansion of macro 'NULL'
  {POC_INVAL, NULL, NULL }
                    ^~~~
../common/pool.c:2461:22: note: in expansion of macro 'POOL_VALUE_INITIALIZER'
   pool_value_t val = POOL_VALUE_INITIALIZER;
                      ^~~~~~~~~~~~~~~~~~~~~~
../common/pool.c: In function 'pool_elem_compare_name':
/code/illumos-gate/proto/root_i386/usr/include/sys/null.h:28:14: error: initialization makes integer from pointer without a cast [-Werror=int-conversion]
 #define NULL ((void *)0)
              ^
../common/pool_internal.h:140:20: note: in expansion of macro 'NULL'
  {POC_INVAL, NULL, NULL }
                    ^~~~
../common/pool.c:2812:21: note: in expansion of macro 'POOL_VALUE_INITIALIZER'
  pool_value_t val = POOL_VALUE_INITIALIZER;
                     ^~~~~~~~~~~~~~~~~~~~~~
/code/illumos-gate/proto/root_i386/usr/include/sys/null.h:28:14: note: (near initialization for 'val.pv_u.u')
 #define NULL ((void *)0)
              ^
../common/pool_internal.h:140:20: note: in expansion of macro 'NULL'
  {POC_INVAL, NULL, NULL }
                    ^~~~
../common/pool.c:2812:21: note: in expansion of macro 'POOL_VALUE_INITIALIZER'
  pool_value_t val = POOL_VALUE_INITIALIZER;
                     ^~~~~~~~~~~~~~~~~~~~~~
../common/pool.c: In function 'pool_elem_compare':
/code/illumos-gate/proto/root_i386/usr/include/sys/null.h:28:14: error: initialization makes integer from pointer without a cast [-Werror=int-conversion]
 #define NULL ((void *)0)
              ^
../common/pool_internal.h:140:20: note: in expansion of macro 'NULL'
  {POC_INVAL, NULL, NULL }
                    ^~~~
../common/pool.c:2873:21: note: in expansion of macro 'POOL_VALUE_INITIALIZER'
  pool_value_t val = POOL_VALUE_INITIALIZER;
                     ^~~~~~~~~~~~~~~~~~~~~~
/code/illumos-gate/proto/root_i386/usr/include/sys/null.h:28:14: note: (near initialization for 'val.pv_u.u')
 #define NULL ((void *)0)
              ^
../common/pool_internal.h:140:20: note: in expansion of macro 'NULL'
  {POC_INVAL, NULL, NULL }
                    ^~~~
../common/pool.c:2873:21: note: in expansion of macro 'POOL_VALUE_INITIALIZER'
  pool_value_t val = POOL_VALUE_INITIALIZER;
                     ^~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors


andy_js
  1. Ship It!
  2. 
      
tsoome
tsoome
Review request changed

Status: Closed (submitted)

Loading...