it is very bad practice to remove debug code. you just can disable it. but do not remove. my -1
11128 SPARC build fails for sun4v picl snmp plugin
Review Request #1919 — Created June 1, 2019 and submitted
A SPARC build fails with: ; /export/home/ptribble/Illumos/topo-gate/usr/src/tools/proto/root_sparc-nd/opt/onbld/bin/sparc/ctfconvert -L VERSION pics/debug.o ctfconvert: file does not contain DWARF data Error code 1 dmake: Warning: Command failed for target `pics/debug.o' Current working directory /export/home/ptribble/Illumos/topo-gate/usr/src/cmd/picl/plugins/sun4v/lib/snmp Looking at the code, it may be cleaner to remove the SNMP_DEBUG pieces entirely, so the fix here does just that.
With the fix, this build error is no longer present.
Dead code should be gone.
Revision 2 (+14 -867)