11125 libpicltree: NULL pointer errors

Review Request #1910 — Created June 1, 2019 and submitted

tsoome
illumos-gate
11125
02418fc...
general
../picltree.c: In function 'picl_hdl_error':
../picltree.c:594:16: error: comparison between pointer and integer [-Werror]
      (hash_val == NULL))
                ^~
../picltree.c: In function 'ptree_hdl_error':
../picltree.c:613:16: error: comparison between pointer and integer [-Werror]
      (hash_val == NULL))
                ^~
In file included from ../picltree.c:131:0:
../picltree.c: In function 'unpiclize_prop':
../ptree_impl.h:55:40: error: comparison between pointer and integer [-Werror]
 #define IS_PICLIZED(x)  ((x)->picl_hdl != NULL)
                                        ^
../picltree.c:1003:7: note: in expansion of macro 'IS_PICLIZED'
  if (!IS_PICLIZED(propp))
       ^~~~~~~~~~~
../picltree.c: In function 'unpiclize_node':
../ptree_impl.h:55:40: error: comparison between pointer and integer [-Werror]
 #define IS_PICLIZED(x)  ((x)->picl_hdl != NULL)
                                        ^
../picltree.c:1025:7: note: in expansion of macro 'IS_PICLIZED'
  if (!IS_PICLIZED(nodep))
       ^~~~~~~~~~~
../picltree.c: In function 'ptree_add_prop':
../ptree_impl.h:55:40: error: comparison between pointer and integer [-Werror]
 #define IS_PICLIZED(x)  ((x)->picl_hdl != NULL)
                                        ^
../picltree.c:1498:7: note: in expansion of macro 'IS_PICLIZED'
   if (IS_PICLIZED(nodep) && !IS_PICLIZED(refobj)) {
       ^~~~~~~~~~~
../ptree_impl.h:55:40: error: comparison between pointer and integer [-Werror]
 #define IS_PICLIZED(x)  ((x)->picl_hdl != NULL)
                                        ^
../picltree.c:1498:30: note: in expansion of macro 'IS_PICLIZED'
   if (IS_PICLIZED(nodep) && !IS_PICLIZED(refobj)) {
                              ^~~~~~~~~~~
../ptree_impl.h:55:40: error: comparison between pointer and integer [-Werror]
 #define IS_PICLIZED(x)  ((x)->picl_hdl != NULL)
                                        ^
../picltree.c:1508:6: note: in expansion of macro 'IS_PICLIZED'
  if (IS_PICLIZED(nodep))
      ^~~~~~~~~~~
../picltree.c: In function 'ptree_add_row_to_table':
../ptree_impl.h:55:40: error: comparison between pointer and integer [-Werror]
 #define IS_PICLIZED(x)  ((x)->picl_hdl != NULL)
                                        ^
../picltree.c:1666:7: note: in expansion of macro 'IS_PICLIZED'
   if (IS_PICLIZED(pobj) || (pobj->prop_table != NULL) ||
       ^~~~~~~~~~~
../ptree_impl.h:55:40: error: comparison between pointer and integer [-Werror]
 #define IS_PICLIZED(x)  ((x)->picl_hdl != NULL)
                                        ^
../picltree.c:1684:6: note: in expansion of macro 'IS_PICLIZED'
  if (IS_PICLIZED(tbl_obj))
      ^~~~~~~~~~~
../picltree.c: In function 'ptree_destroy_node':
../ptree_impl.h:55:40: error: comparison between pointer and integer [-Werror]
 #define IS_PICLIZED(x)  ((x)->picl_hdl != NULL)
                                        ^
../picltree.c:1938:6: note: in expansion of macro 'IS_PICLIZED'
  if (IS_PICLIZED(nodep)) {
      ^~~~~~~~~~~
../picltree.c: In function 'ptree_add_node':
../ptree_impl.h:55:40: error: comparison between pointer and integer [-Werror]
 #define IS_PICLIZED(x)  ((x)->picl_hdl != NULL)
                                        ^
../picltree.c:2062:6: note: in expansion of macro 'IS_PICLIZED'
  if (IS_PICLIZED(pnodep))
      ^~~~~~~~~~~
cc1: all warnings being treated as errors


jlevon
  1. Ship It!
  2. 
      
wiedi
  1. Ship It!
  2. 
      
tsoome
tsoome
Review request changed

Status: Closed (submitted)

Loading...