RFE: Would like "hostname -s"

Review Request #191 — Created May 12, 2016 and submitted June 1, 2016, 9:52 a.m.

Information
Owner:	lotheac
Repository:	illumos-gate
Branch:
Bugs:
Depends On:
Reviewers
Groups:	general
People:

Description

https://www.illumos.org/issues/3758

Testing Done

Issues

0
0
2
1
All Issues: 3

Description	From	Last Updated
Don't forget to update the usage message to describe -s.	gdamore	May 12, 2016, 7:14 p.m.
What happens if c_hostname does not contain any periods? Won't strcspn return 0 and therefore we end up printing an ...	jeffpc	May 12, 2016, 7:14 p.m.
No need for this te thing with madoc.	gdamore	May 12, 2016, 7:14 p.m.

usr/src/cmd/hostname/hostname.c (Diff revision 1)

Show all issues

Don't forget to update the usage message to describe -s.

usr/src/man/man1/hostname.1 (Diff revision 1)
Show all issues
```
No need for this te thing with madoc.
```

usr/src/cmd/hostname/hostname.c (Diff revision 1)

Show all issues

What happens if c_hostname does not contain any periods?  Won't strcspn return 0 and therefore we end up printing an empty string?  Should this print the whole string if there is no "domain" info?

lotheac May 12, 2016, 7:12 p.m.

No, if there are no periods this will print the entire string. Using strcspn like this is a somewhat common idiom (it returns the length of the string, ie. the index of the null terminator, if it doesn't encounter any characters from s2)

jeffpc May 12, 2016, 7:14 p.m.
```
Sorry, I mixed up strcspn and strspn.
```

Diff:

Revision 2 (+35 -24)

Show changes

	usr/src/cmd/hostname/hostname.c
	usr/src/man/man1/hostname.1

Ship it!

```
Ship It!
```

Does it make sense to ignore '-s' when setting the hostname?

lotheac May 13, 2016, 7:20 a.m.

The other alternative is to give an error. I don't really have a strong opinion, but OpenBSD's hostname(1) works like this as well - '-s' becomes a no-op if you give an argument.