11085 loader: block all output via tem while tem is reconfigured

Review Request #1874 — Created May 30, 2019 and submitted

tsoome
illumos-gate
11085
5f9a3c4...
general
11085 loader: block all output via tem while tem is reconfigured


  • 0
  • 0
  • 4
  • 0
  • 4
Description From Last Updated
domag02
  1. C-style and other code improvements unrelated to this issue.
  2. usr/src/boot/sys/boot/common/tem.c (Diff revision 1)
     
     

    malloc + bzero = calloc.

  3. usr/src/boot/sys/boot/common/tem.c (Diff revision 1)
     
     

    Missing a blank before the / operator.

  4. usr/src/boot/sys/boot/common/tem.c (Diff revision 1)
     
     

    Should be:

        case A_CSI: {
            int i;
    
            tem->tvs_curparam = 0;
            tem->tvs_paramval = 0;
            tem->tvs_gotparam = B_FALSE;
            /* clear the parameters */
            for (i = 0; i < TEM_MAXPARAMS; i++)
                tem->tvs_params[i] = -1;
            tem->tvs_state = A_STATE_CSI;
            break;
        }
    
  5. usr/src/boot/sys/boot/common/tem.c (Diff revision 1)
     
     

    Should be:

        if (isdigit(ch)) {
    
  6. usr/src/boot/sys/boot/common/tem.c (Diff revision 1)
     
     

    Missing a blank before the / operator.

  7. usr/src/boot/sys/boot/common/tem.c (Diff revision 1)
     
     
    Unnecessary extra whitespace.
  8. 
      
tsoome
tsoome
Review request changed

Status: Closed (submitted)

Loading...