11055 loader: zfs reader cstyle cleanup

Review Request #1852 - Created May 21, 2019 and updated

Information
Toomas Soome
illumos-gate
11055
4e08708...
Reviewers
general
11055 loader: zfs reader cstyle cleanup

  

Issues

  • 30
  • 4
  • 0
  • 34
Description From Last Updated
Déjà vu... Type of found variable should be bool. Gergő Mihály Doma Gergő Mihály Doma
Format string - argument type mismatch: type of j variable is unsigned int. Gergő Mihály Doma Gergő Mihály Doma
"Never use the boolean negation operator (!) with non-boolean expressions." Gergő Mihály Doma Gergő Mihály Doma
Type of is_new variable (and also the is_newer argument) should be bool. Gergő Mihály Doma Gergő Mihály Doma
0 vs NULL. Gergő Mihály Doma Gergő Mihály Doma
0 vs NULL. Gergő Mihály Doma Gergő Mihály Doma
"Numerical constants should not be coded directly. The #define feature of the C preprocessor should be used to assign a ... Gergő Mihály Doma Gergő Mihály Doma
"Numerical constants should not be coded directly. The #define feature of the C preprocessor should be used to assign a ... Gergő Mihály Doma Gergő Mihály Doma
Optional, drop this if you think it isn't important: buf[0] = '\0'; Gergő Mihály Doma Gergő Mihály Doma
"A blank line should always be used ... After local variable declarations." Gergő Mihály Doma Gergő Mihály Doma
Type of first variable should be bool. Gergő Mihály Doma Gergő Mihály Doma
is_newer should be bool. Gergő Mihály Doma Gergő Mihály Doma
"Numerical constants should not be coded directly. The #define feature of the C preprocessor should be used to assign a ... Gergő Mihály Doma Gergő Mihály Doma
"Numerical constants should not be coded directly. The #define feature of the C preprocessor should be used to assign a ... Gergő Mihály Doma Gergő Mihály Doma
"Numerical constants should not be coded directly. The #define feature of the C preprocessor should be used to assign a ... Gergő Mihály Doma Gergő Mihály Doma
"Numerical constants should not be coded directly. The #define feature of the C preprocessor should be used to assign a ... Gergő Mihály Doma Gergő Mihály Doma
Is it safe to expect that only two types of ZAP can exist? See the implementation of zap_lookup() in this ... Gergő Mihály Doma Gergő Mihály Doma
"Numerical constants should not be coded directly. The #define feature of the C preprocessor should be used to assign a ... Gergő Mihály Doma Gergő Mihály Doma
"Numerical constants should not be coded directly. The #define feature of the C preprocessor should be used to assign a ... Gergő Mihály Doma Gergő Mihály Doma
Is it safe to expect that only two types of ZAP can exist? Gergő Mihály Doma Gergő Mihály Doma
"Numerical constants should not be coded directly. The #define feature of the C preprocessor should be used to assign a ... Gergő Mihály Doma Gergő Mihály Doma
Possible buffer overrun: component array can hold up to 256 bytes, but zap_rlookup can write into it at most 65535 ... Gergő Mihály Doma Gergő Mihály Doma
"Numerical constants should not be coded directly. The #define feature of the C preprocessor should be used to assign a ... Gergő Mihály Doma Gergő Mihály Doma
"Numerical constants should not be coded directly. The #define feature of the C preprocessor should be used to assign a ... Gergő Mihály Doma Gergő Mihály Doma
Is it safe to expect that only two types of ZAP can exist? Gergő Mihály Doma Gergő Mihály Doma
"Numerical constants should not be coded directly. The #define feature of the C preprocessor should be used to assign a ... Gergő Mihály Doma Gergő Mihály Doma
Is it safe to expect that only two types of ZAP can exist? Gergő Mihály Doma Gergő Mihály Doma
"If one arm of an if-else statement contains braces, all arms should contain braces." Gergő Mihály Doma Gergő Mihály Doma
"Numerical constants should not be coded directly. The #define feature of the C preprocessor should be used to assign a ... Gergő Mihály Doma Gergő Mihály Doma
"Numerical constants should not be coded directly. The #define feature of the C preprocessor should be used to assign a ... Gergő Mihály Doma Gergő Mihály Doma
Rob Johnston
Gergő Mihály Doma
Toomas Soome
Toomas Soome
Review request changed

Change Summary:

usr/src/boot/lib/libstand/zfs/zfsimpl.c: 1442: missing space after (void) cast
usr/src/boot/lib/libstand/zfs/zfsimpl.c: 1737: space after cast

Commit:

-9ac02fb709b9f0e6713b3f205540577e1f90b90e
+4e0870808d6fb48d32d7839d3fd280103587fb34

Diff:

Revision 3 (+157 -137)

Show changes

Loading...