11048 need a way to disable SMT

Review Request #1848 — Created May 20, 2019 and submitted

jjelinek
illumos-gate
general

Provides a mechanism for disabling simultaneous multi-threading (hyper-threading).

Testing notes in bug report.

  • 0
  • 0
  • 4
  • 3
  • 7
Description From Last Updated
tsoome
  1. 
      
  2. usr/src/cmd/lp/include/printers.h (Diff revision 1)
     
     

    red ugliness

  3. usr/src/uts/common/disp/disp.c (Diff revision 1)
     
     

    red ugliness

  4. 
      
ptribble
  1. Just an aside: the file usr/src/uts/sun4u/starcat/io/drmach.c will no longer exist when 10864 integrates, which it should soon.
  2. 
      
citrus
  1. LGTM, and I've tested this on OmniOS. Just a few nits.

  2. usr/src/cmd/lp/include/printers.h (Diff revision 1)
     
     

    Whitespace nit

    (nice centralisation of the fixup for duplicate definitions though)

  3. usr/src/cmd/psradm/psradm.c (Diff revision 1)
     
     

    Given the obvious effort that has been made to use the generic term SMT in place of the Intel proprietry Hyper-threading, should the same be done here?

  4. usr/src/man/man1m/psradm.1m (Diff revision 1)
     
     

    its SMT siblings "placed" in the ...?

  5. 
      
jjelinek
citrus
  1. Ship It!
  2. 
      
domag02
  1. (Drop these issues, if you think they aren't important.)

  2. usr/src/cmd/psradm/psradm.c (Diff revision 2)
     
     

    With the usage of numbered argument specification, you can avoid the repetition of arguments.
    Example:

        (void) fprintf(stderr, "usage:\n"
            "\t%1$s [-F] -f|-n|-i|-s [-v] processor_id ...\n"
            "\t%1$s -a -f|-n|-i [-v]\n"
            "\t%1$s -aS [-v]\n",
            cmdname);
    
    1. John's change here was just following the previous precedent, so I'd like to keep his change as-is.

  3. usr/src/cmd/psrinfo/psrinfo.c (Diff revision 2)
     
     

    Same + unnecessary whitespace between 'usage:' and '\n'.

    1. This white space was pre-existing so I'd like to keep John's change as-is.

  4. 
      
jjelinek
Review request changed

Status: Closed (submitted)

Loading...