6143 Want zoneadm list option for non-global zones only

Review Request #1847 — Created May 19, 2019 and submitted Aug. 19, 2019, 7:11 p.m.

Information
Owner:	ryaeng
Repository:	illumos-gate
Branch:	master
Bugs:
Depends On:
Commit:	9b0d0be...
Reviewers
Groups:	general
People:

Description

6143 Want zoneadm list option for non-global zones only

Testing Done

Issues

0
0
4
0
All Issues: 4

Description	From	Last Updated
This variable should be called exclude_global	citrus	May 22, 2019, 3:27 a.m.
Add -n here too?	citrus	May 22, 2019, 3:27 a.m.
Move this down to keep the options in alphabetic order.	citrus	May 22, 2019, 3:27 a.m.
I think you might be missing an .sp line before the .ne 2 line here? At least, it looks like ...	jclulow	May 23, 2019, 5:25 a.m.

usr/src/cmd/zoneadm/zoneadm.c (Diff revision 1)
Show all issues
```
This variable should be called exclude_global
```
usr/src/man/man1m/zoneadm.1m (Diff revision 1)
Show all issues
```
Add -n here too?
```

usr/src/man/man1m/zoneadm.1m (Diff revision 1)

Show all issues

Move this down to keep the options in alphabetic order.

Change Summary:

Fixed issues suggested by Andy Fiddaman.

Commit:

-	2c3789e5d283c5faf48394c3b4b5f88ad9364749
+	411430b528d545e3ec02939f454e1490b6c66b15

Diff:

Revision 2 (+28 -10)

Show changes

	usr/src/cmd/zoneadm/zoneadm.c
	usr/src/man/man1m/zoneadm.1m

This is looking good! One small nit in the manual page markup, but I think you are otherwise ready to go.

usr/src/man/man1m/zoneadm.1m (Diff revision 2)

Show all issues

I think you might be missing an .sp line before the .ne 2 line here? At least, it looks like the other arguments in this section (starting at L312) have that.

Commit:

-	411430b528d545e3ec02939f454e1490b6c66b15
+	9b0d0be50faf8e346c799d886d4f275a9da56955

Diff:

Revision 3 (+29 -10)

Show changes

	usr/src/cmd/zoneadm/zoneadm.c
	usr/src/man/man1m/zoneadm.1m

Ship it!

```
Ship It!
```

You have a pending review.

Review Board 3.0.18

6143 Want zoneadm list option for non-global zones only

Change Summary:

Commit:

Diff:

Commit:

Diff:

Status: Closed (submitted)