10939 libdiskstatus trusts disk mode sense data to its death

Review Request #1833 — Created May 9, 2019 and submitted

rm
illumos-gate
master
10939
9035533...
general

10939 libdiskstatus trusts disk mode sense data to its death
Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
Reviewed by: Rob Johnston <rob.johnston@joyent.com>



  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
tsoome
  1. Ship It!
  2. 
      
domag02
  1. 
      
  2. Typo? ('s/hdr->length/page_code/')

    Based on the others, I think this should be:

            dprintf("\nMode sense page 0x%x: has header length for zero\n",
                page_code);
    

    or with different wording:

            dprintf("\nMode sense page 0x%x: header length is zero\n",
                page_code);
    
    1. Good catch, thanks.
  3. 
      
rm
domag02
  1. Ship It!
  2. 
      
tsoome
  1. Ship It!
  2. 
      
citrus
  1. Ship It!
  2. 
      
rm
Review request changed

Status: Closed (submitted)

Loading...