10939 libdiskstatus trusts disk mode sense data to its death

Review Request #1833 — Created May 9, 2019 and submitted June 6, 2019, 3:56 a.m.

Information
Owner:	rm
Repository:	illumos-gate
Branch:	master
Bugs:	10939
Depends On:
Commit:	9035533...
Reviewers
Groups:	general
People:

Description

10939 libdiskstatus trusts disk mode sense data to its death
Reviewed by: Jerry Jelinek <jerry.jelinek@joyent.com>
Reviewed by: Rob Johnston <rob.johnston@joyent.com>

Testing Done

Issues

0
0
1
0
All Issues: 1

Description	From	Last Updated
Typo? ('s/hdr->length/page_code/') Based on the others, I think this should be: dprintf("\nMode sense page 0x%x: has header length for zero\n", ...	domag02	May 9, 2019, 11:05 p.m.

Ship it!

```
Ship It!
```

usr/src/lib/fm/libdiskstatus/common/ds_scsi_uscsi.c (Diff revision 1)

Show all issues

Typo? ('s/hdr->length/page_code/')
Based on the others, I think this should be:
        dprintf("\nMode sense page 0x%x: has header length for zero\n",
            page_code);

or with different wording:
        dprintf("\nMode sense page 0x%x: header length is zero\n",
            page_code);