10878 i86pc/i86xpv: comparison between pointer and integer

Review Request #1812 - Created April 28, 2019 and submitted

Information
Toomas Soome
illumos-gate
10878
682b8f5...
Reviewers
general
In file included from ../../common/sys/model.h:35:0,
                 from ../../common/sys/resource.h:221,
                 from ../../common/sys/user.h:73,
                 from ../../common/sys/proc.h:36,
                 from ../../common/sys/systm.h:40,
                 from ../../common/os/brand.c:27:
../../common/os/brand.c: In function 'brand_solaris_elfexec':
../../common/os/brand.c:721:23: error: comparison between pointer and integer [-
Werror]
  ASSERT(sed.sed_entry != NULL);
                       ^
../../common/sys/debug.h:59:29: note: in definition of macro 'ASSERT'
 #define ASSERT(EX) ((void)((EX) || assfail(#EX, __FILE__, __LINE__)))
                             ^~
../../common/os/brand.c:722:22: error: comparison between pointer and integer [-
Werror]
  ASSERT(sed.sed_phdr != NULL);
                      ^
../../common/sys/debug.h:59:29: note: in definition of macro 'ASSERT'
 #define ASSERT(EX) ((void)((EX) || assfail(#EX, __FILE__, __LINE__)))
                             ^~

In file included from ../../common/sys/model.h:35:0,
                 from ../../common/sys/resource.h:221,
                 from ../../common/sys/user.h:73,
                 from ../../common/sys/proc.h:36,
                 from ../../common/sys/systm.h:40,
                 from ../../common/krtld/kobj.c:38:
../../common/krtld/kobj.c: In function 'crypto_es_hash':
../../common/krtld/kobj.c:2721:23: error: comparison between pointer and integer
 [-Werror]
   ASSERT(shp->sh_addr != NULL);
                       ^
../../common/sys/debug.h:59:29: note: in definition of macro 'ASSERT'
 #define ASSERT(EX) ((void)((EX) || assfail(#EX, __FILE__, __LINE__)))
                             ^~

cc1: all warnings being treated as errors

  
John Levon
Toomas Soome
Review request changed

Status: Closed (submitted)

Loading...