10865 ibmf: comparison between pointer and integer

Review Request #1798 - Created April 28, 2019 and submitted

Information
Toomas Soome
illumos-gate
10865
aa41524...
Reviewers
general
In file included from ../../common/sys/model.h:35:0,
                 from ../../common/sys/resource.h:221,
                 from ../../common/sys/user.h:73,
                 from ../../common/sys/proc.h:36,
                 from ../../common/sys/systm.h:40,
                 from ../../common/sys/conf.h:57,
                 from ../../common/sys/ib/mgt/ibmf/ibmf_impl.h:39,
                 from ../../common/io/ib/mgt/ibmf/ibmf_wqe.c:30:
../../common/io/ib/mgt/ibmf/ibmf_wqe.c: In function 'ibmf_i_init_send_wqe':
../../common/io/ib/mgt/ibmf/ibmf_wqe.c:873:21: error: comparison between pointer and integer [-Werror]
  ASSERT(swrp->wr_id != NULL);
                     ^
../../common/sys/debug.h:59:29: note: in definition of macro 'ASSERT'
 #define ASSERT(EX) ((void)((EX) || assfail(#EX, __FILE__, __LINE__)))
                             ^~

In file included from ../../common/sys/model.h:35:0,
                 from ../../common/sys/resource.h:221,
                 from ../../common/sys/user.h:73,
                 from ../../common/sys/proc.h:36,
                 from ../../common/sys/systm.h:40,
                 from ../../common/sys/conf.h:57,
                 from ../../common/sys/ib/mgt/ibmf/ibmf_impl.h:39,
                 from ../../common/io/ib/mgt/ibmf/ibmf_recv.c:31:
../../common/io/ib/mgt/ibmf/ibmf_recv.c: In function 'ibmf_send_busy':
../../common/io/ib/mgt/ibmf/ibmf_recv.c:1589:21: error: comparison between pointer and integer [-Werror]
  ASSERT(swrp->wr_id != NULL);
                     ^
../../common/sys/debug.h:59:29: note: in definition of macro 'ASSERT'
 #define ASSERT(EX) ((void)((EX) || assfail(#EX, __FILE__, __LINE__)))
                             ^~

In file included from ../../common/sys/model.h:35:0,
                 from ../../common/sys/resource.h:221,
                 from ../../common/sys/user.h:73,
                 from ../../common/sys/proc.h:36,
                 from ../../common/sys/systm.h:40,
                 from ../../common/sys/conf.h:57,
                 from ../../common/sys/ib/mgt/ibmf/ibmf_impl.h:39,
                 from ../../common/io/ib/mgt/ibmf/ibmf_send.c:33:
../../common/io/ib/mgt/ibmf/ibmf_send.c: In function 'ibmf_i_handle_send_completion':
../../common/io/ib/mgt/ibmf/ibmf_send.c:271:20: error: comparison between pointer and integer [-Werror]
  ASSERT(wcp->wc_id != NULL);
                    ^
../../common/sys/debug.h:59:29: note: in definition of macro 'ASSERT'
 #define ASSERT(EX) ((void)((EX) || assfail(#EX, __FILE__, __LINE__)))
                             ^~

cc1: all warnings being treated as errors

  
Robert Mustacchi
Toomas Soome
Toomas Soome
Review request changed

Status: Closed (submitted)

Loading...